Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Reland 2: Add Impeller Metal support in the embedder API (#42411) #42597

Merged
merged 4 commits into from
Jun 7, 2023
Merged

[Impeller] Reland 2: Add Impeller Metal support in the embedder API (#42411) #42597

merged 4 commits into from
Jun 7, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Jun 6, 2023

This reverts commit 350a12b + fixes bugs.

Reworked the surface wrapping to use a valid descriptor when wrapping the drawable.

@bdero bdero self-assigned this Jun 6, 2023
@bdero bdero force-pushed the bdero/reland-metal-embedder branch from 1fb3396 to 86e9f48 Compare June 6, 2023 18:59
@bdero bdero requested review from jonahwilliams and zanderso June 7, 2023 02:30
@bdero bdero force-pushed the bdero/reland-metal-embedder branch from 33afdc6 to 6053e8e Compare June 7, 2023 02:37
jonahwilliams
jonahwilliams approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero
Copy link
Member Author

bdero commented Jun 7, 2023 •
edited
Loading

OK, so looking at the benchmarks, I think this next attempt is good to go. None of the benchmarks are printing validation errors anymore, and the "simple animation" benchmark also didn't regress during the last attempt.
Another thing I fixed with my last attempt at landing this was an extra RT copy into the optional, which was surprisingly ~2% of the CPU profile because it wasn't doing a move assignment.

@bdero bdero merged commit ef7b773 into flutter:main Jun 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
094717b 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
c2e1368 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
03e415e 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
cccca68 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
8ffa149 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
5d6718b 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
8c08c54 
…dder API (flutter#42411) (flutter/engine#42597)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
ef7b77335 [Impeller] Reland 2: Add Impeller Metal support in the embe…
c2c7163 
…dder API (flutter#42411) (flutter/engine#42597)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (#…
2754514 
…128460)

flutter/engine@4f4486b...1089ce6

2023-06-07 jonahwilliams@google.com [Impeller] Add buffer to texture
blit for Vulkan. (flutter/engine#41706)
2023-06-07 chris@bracken.jp [macOS] Add platformview creation parameter
support (flutter/engine#42607)
2023-06-07 30870216+gaaclarke@users.noreply.github.com [Impeller] Added
a switch to turn on vulkan (flutter/engine#42585)
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from f8220fa3a729
to 15a29438b099 (1 revision) (flutter/engine#42627)
2023-06-07 jacksongardner@google.com Bump Chrome version to 114 for
testing (flutter/engine#42623)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from d607cbb0db78 to
773765ca1dd2 (7 revisions) (flutter/engine#42624)
2023-06-07 jpnurmi@gmail.com [Linux][a11y] implement
AtkText::get_text/string_at_offset() (flutter/engine#38144)
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 176989ad00cc
to f8220fa3a729 (1 revision) (flutter/engine#42621)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from ee90e9ae2e62 to
d607cbb0db78 (1 revision) (flutter/engine#42618)
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 1ad4ae4d63bf
to 176989ad00cc (1 revision) (flutter/engine#42617)
2023-06-07 dkwingsmt@users.noreply.github.com Revert "[Android] Return
keyboard pressed state" (flutter/engine#42616)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from bde894438f29 to
ee90e9ae2e62 (1 revision) (flutter/engine#42614)
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... (flutter/engine#42613)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from cd3e1665dcd1 to
bde894438f29 (1 revision) (flutter/engine#42612)
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 16841d6256da
to 1ad4ae4d63bf (1 revision) (flutter/engine#42611)
2023-06-07 bdero@google.com [Impeller] Reland 2: Add Impeller Metal
support in the embedder API (#42411) (flutter/engine#42597)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from a01f49f539ab to
cd3e1665dcd1 (1 revision) (flutter/engine#42610)
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... (flutter/engine#42609)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 521b8c4bb011 to
a01f49f539ab (4 revisions) (flutter/engine#42608)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from cef18d10b363 to
521b8c4bb011 (1 revision) (flutter/engine#42605)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lpbkSRJBMkPs to sEHtHM1iFt79
  fuchsia/sdk/core/mac-amd64 from atrYtfHWi2cm to ojwVlxZWrbsG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees

@bdero bdero

Labels
e: impeller embedder Related to the embedder API platform-android platform-fuchsia platform-ios
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdero @jonahwilliams