Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4f4486b00be2
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1089ce6874cf
Choose a head ref
  • 20 commits
  • 99 files changed
  • 8 contributors

Commits on Jun 7, 2023

  1. Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) (#42605) 

    https://skia.googlesource.com/skia.git/+log/cef18d10b363..521b8c4bb011

2023-06-06 robertphillips@google.com Revert "Add unit test for large images"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2ad6010 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) (#42608) 

    https://skia.googlesource.com/skia.git/+log/521b8c4bb011..a01f49f539ab

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 521ddd00b973 to c520912239f0 (4 revisions)
2023-06-06 johnstiles@google.com Allow WGSL code with warnings to compile successfully.
2023-06-06 johnstiles@google.com Change WGSL indentation level to 2 spaces.
2023-06-06 johnstiles@google.com Add WGSL support for do-while loops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e00b539 View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Mac SDK from atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... ( 

    #42609)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    46e7e3c View commit details
    Browse the repository at this point in the history

  4. Roll Skia from a01f49f539ab to cd3e1665dcd1 (1 revision) (#42610) 

    https://skia.googlesource.com/skia.git/+log/a01f49f539ab..cd3e1665dcd1

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3e5c6411ba05 to fd2d24b01b67 (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9d3ba40 View commit details
    Browse the repository at this point in the history

  5. [Impeller] Reland 2: Add Impeller Metal support in the embedder API (#… 

    …42411) (#42597)

This reverts commit
350a12b
+ fixes bugs.

Reworked the surface wrapping to use a valid descriptor when wrapping
the drawable.
    @bdero
    bdero authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ef7b773 View commit details
    Browse the repository at this point in the history

  6. Roll ANGLE from 16841d6256da to 1ad4ae4d63bf (1 revision) (#42611) 

    https://chromium.googlesource.com/angle/angle.git/+log/16841d6256da..1ad4ae4d63bf

2023-06-06 yuxinhu@google.com Clean up EGLPreRotation Test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9524b80 View commit details
    Browse the repository at this point in the history

  7. Roll Skia from cd3e1665dcd1 to bde894438f29 (1 revision) (#42612) 

    https://skia.googlesource.com/skia.git/+log/cd3e1665dcd1..bde894438f29

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 721c15efaa70 to 1ad4ae4d63bf (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    73ee17e View commit details
    Browse the repository at this point in the history

  8. Roll Fuchsia Linux SDK from lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x… 

    …... (#42613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ea10af1 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from bde894438f29 to ee90e9ae2e62 (1 revision) (#42614) 

    https://skia.googlesource.com/skia.git/+log/bde894438f29..ee90e9ae2e62

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b54c2bdc9713 to bb33478c7dad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b6586ab View commit details
    Browse the repository at this point in the history

  10. Revert "[Android] Return keyboard pressed state" (#42616) 

    Reverts #41695 due to internal bug report b/284945818.

cc @bleroux let's investigate some day.
    @dkwingsmt
    dkwingsmt authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    61b2b50 View commit details
    Browse the repository at this point in the history

  11. Roll ANGLE from 1ad4ae4d63bf to 176989ad00cc (1 revision) (#42617) 

    https://chromium.googlesource.com/angle/angle.git/+log/1ad4ae4d63bf..176989ad00cc

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9e0b5e8b8a85 to fe5f79e217c4 (537 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2ed4e75 View commit details
    Browse the repository at this point in the history

  12. Roll Skia from ee90e9ae2e62 to d607cbb0db78 (1 revision) (#42618) 

    https://skia.googlesource.com/skia.git/+log/ee90e9ae2e62..d607cbb0db78

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b8f3bbf465f8 to b54c2bdc9713 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9237e39 View commit details
    Browse the repository at this point in the history

  13. Roll ANGLE from 176989ad00cc to f8220fa3a729 (1 revision) (#42621) 

    https://chromium.googlesource.com/angle/angle.git/+log/176989ad00cc..f8220fa3a729

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 0c2e936905ea to f7613775cdc7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a6f7c77 View commit details
    Browse the repository at this point in the history

  14. [Linux][a11y] implement AtkText::get_text/string_at_offset() (#38144) 

    This PR implements `AtkText::get_string_at_offset()` (and the deprecated `AtkText::get_text_at_offset()` still used by e.g. Orca) for `FlAccessibleTextField` to allow Orca to read out loud the current character while moving the text cursor around.

### Before (unmute to hear the screen reader)

[textfield-a11y-before.webm](https://user-images.githubusercontent.com/140617/206556644-fb4f4df8-acca-4d97-86d5-7120f0a4871d.webm)

### After (unmute to hear the screen reader)

[textfield-a11y-after.webm](https://user-images.githubusercontent.com/140617/206556678-4fbf9112-291e-4518-a258-e9ca33469430.webm)

Fixes: flutter/flutter#113049

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jpnurmi
    jpnurmi authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    671a846 View commit details
    Browse the repository at this point in the history

  15. Roll Skia from d607cbb0db78 to 773765ca1dd2 (7 revisions) (#42624) 

    https://skia.googlesource.com/skia.git/+log/d607cbb0db78..773765ca1dd2

2023-06-07 drott@chromium.org [Fontations] Support makeClone() for variations
2023-06-07 johnstiles@google.com Demonstrate function-parameter assignment issue in unit test.
2023-06-07 johnstiles@google.com Add unit tests to WGSL that rely on dead-return synthesis.
2023-06-07 johnstiles@google.com Add trailing `return` to functions that lack an unconditional return.
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c520912239f0 to 5c35de42bbc6 (2 revisions)
2023-06-07 johnstiles@google.com Fix test disable for OutParamsDoubleSwizzle.
2023-06-07 kjlubick@google.com Remove some spaces from the gainmap sksl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a466c6b View commit details
    Browse the repository at this point in the history

  16. Bump Chrome version to 114 for testing (#42623)

    @eyebrowsoffire
    eyebrowsoffire authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8bdf653 View commit details
    Browse the repository at this point in the history

  17. Roll ANGLE from f8220fa3a729 to 15a29438b099 (1 revision) (#42627) 

    https://chromium.googlesource.com/angle/angle.git/+log/f8220fa3a729..15a29438b099

2023-06-07 prashanthsw@google.com Migrate Android NDK to CIPD [1/2]

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2cd02eb View commit details
    Browse the repository at this point in the history

  18. [Impeller] Added a switch to turn on vulkan (#42585) 

    fixes flutter/flutter#128286

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f5007e9 View commit details
    Browse the repository at this point in the history

  19. [macOS] Add platformview creation parameter support (#42607) 

    Previously, when creating native platform views on macOS, we ignored any parameters passed via the framework side "params" argument in the "create" method call, and instead always passed a nil value to the FlutterPlatformViewFactory. This made it impossible for users of macOS platform views to pass constructor arguments to the NSView subclass implementing the platform view.

We now decode the arguments data using the codec specified by the `FlutterPlatformViewFactory` and pass them through to the `[FlutterPlatformViewFactory createWithIdentifier:arguments:]` method where the platform view author can make use of them.

Fixes: flutter/flutter#124723

This is a part of the broader macOS platform view support effort: flutter/flutter#41722

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    71c9d51 View commit details
    Browse the repository at this point in the history

  20. [Impeller] Add buffer to texture blit for Vulkan. (#41706) 

    Work towards flutter/flutter#123468

In order to support the usage of BufferView, I generalized the tracked buffer type from DeviceBuffer to Buffer. Should be mostly safe!

I confirmed that this runs correctly under moltenvk but I'm uncertain if there are additional ways to validate.
    @jonahwilliams
    jonahwilliams authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1089ce6 View commit details
    Browse the repository at this point in the history
Loading