This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run flutter license script with dart --intrepret_irregexp runtime option
#41646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For extremely large RegExp's that are used in flutter license script, this is faster than running unoptimized code. For normal-sized RegExp's optimized code is expected to be faster.
aam
changed the title
--intrepret_irregexp runtime option
zanderso
reviewed
May 1, 2023
| --src ../../.. \ | ||
| --out ../../../out/license_script_output \ | ||
| --golden ../../ci/licenses_golden \ | ||
| dart --enable-asserts --interpret_irregexp lib/main.dart \ |
There was a problem hiding this comment.
Awesome. Please add a comment here that explains why the flag is needed and include the url for the GitHub issue. Thanks!
zanderso
approved these changes
May 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2023
…125845) flutter/engine@3fa6084...7d87410 2023-05-01 ychris@google.com Update xcode to 14e222b (flutter/engine#41640) 2023-05-01 aam@google.com Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646) 2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645) 2023-05-01 ychris@google.com Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extremely large RegExp's that are used in flutter license script, running interpreter-based implementation is faster than running generated unoptimized code. For normal-sized RegExp's optimized code is expected to be faster.
Local testing shows 5x speed up on full license script run (311s vs 1430s).
Should help with flutter/flutter#118193