Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Run flutter license script with dart --intrepret_irregexp runtime option #41646

Merged
merged 5 commits into from
May 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ci/licenses.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,15 @@ function run_tests() (
# Runs in a subshell.
function collect_licenses() (
cd "$SRC_DIR/flutter/tools/licenses"
dart --enable-asserts lib/main.dart \
--src ../../.. \
--out ../../../out/license_script_output \
--golden ../../ci/licenses_golden \
# `--interpret_irregexp`` tells dart to use interpreter mode for running
# the regexp matching, rather than generating machine code for it.
# For very large RegExps that are currently used in license script using
# interpreter is faster than using unoptimized machine code, which has
# no chance of being optimized(due to its size).
dart --enable-asserts --interpret_irregexp lib/main.dart \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please add a comment here that explains why the flag is needed and include the url for the GitHub issue. Thanks!

--src ../../.. \
--out ../../../out/license_script_output \
--golden ../../ci/licenses_golden \
"${QUIET}"
)

Expand Down