-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to audit the ci/builders
subbuilds:
https://github.com/flutter/engine/blob/58cc54197a5486044a9fdadec707f8d0b66d1d61/ci/builders/mac_unopt.json#LL65C35-L65C40
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/mac_android_aot_engine.json: "sdk_version": "14c18"
./ci/builders/README.md: { "sdk_version": "14c18" }
./ci/builders/mac_unopt.json: "sdk_version": "14c18"
./ci/builders/mac_unopt.json: "ios-16-2_14c18",
./ci/builders/mac_unopt.json: "sdk_version": "14c18"
./ci/builders/mac_unopt.json: "sdk_version": "14c18"
./ci/builders/mac_unopt.json: "ios-16-2_14c18",
./ci/builders/mac_unopt.json: "sdk_version": "14c18"
ci/builders/mac_unopt.json
Outdated
"ios-16-3_14e222b", | ||
"ios-16-0_14a5294e" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note if you land #41532 this will need to become:
"ios-16-3_14e222b",
"ios-16-2_14c18",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 16.2 for scenario apps, will rebase when #41532 lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased.
|
It's
|
update builderse fix: 16.3 -> 16.4 makes scenario apps runs on iOS 16.2
…125845) flutter/engine@3fa6084...7d87410 2023-05-01 ychris@google.com Update xcode to 14e222b (flutter/engine#41640) 2023-05-01 aam@google.com Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646) 2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645) 2023-05-01 ychris@google.com Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Engine part of. flutter/flutter#125814
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.