Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Delete io.flutter.app android v1 embedding" (#32232) #32236

Closed
wants to merge 1 commit into from

Conversation

GaryQian
Copy link
Contributor

This reverts commit 0522b48.

Based off of #29248

go/flutter-delete-android-v1-embedding

Deletes the non-plugin related parts of io.flutter.app/* of the v1 android embedding.

This is the first and safest phase of the v1 embedding removal. There is already a build warning that warns against using v1 embedding which can be modified to remove the override option after this as apps will no longer compile without migration.

v1 plugin registry is left intact for now.

@GaryQian
Copy link
Contributor Author

google3 failures need to be patched first: https://fusion2.corp.google.com/presubmit/tap/436911147/OCL:436911147:BASE:436912137:1648104490959:5c96d64e/targets

Mostly involves removing the io.flutter.app.FlutterApplication usages in the AndroidManifests.

@zanderso
Copy link
Member

From PR review triage: Adding the WIP tag. Please remove and add reviewers if I'm mistaken.

@chinmaygarde
Copy link
Member

@GaryQian Any updates after your last comment in March? If we are not going to land this, can we close it?

@chinmaygarde
Copy link
Member

cc @blasten

@GaryQian
Copy link
Contributor Author

GaryQian commented May 5, 2022

I'm currently landing large scale changes that remove v1 embedding from google3. I may try this change again soon as most of the first round of rosie changes have landed.

@chinmaygarde
Copy link
Member

Any updates on trying to get rid of this code anytime soon? Closing it for now but feel free to re-open once progress can be made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Work in progress (WIP) Not ready (yet) for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants