Deprecate android v1 embedding #29248
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -47,113 +39,6 @@ public ShimRegistrar(@NonNull String pluginId, @NonNull Map<String, Object> glob | |||
| this.globalRegistrarMap = globalRegistrarMap; | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
These removed methods are from the deprecated PluginRegistry in PluginRegistry.java
There was a problem hiding this comment.
cc @bparrishMines Can you verify these plugin registry methods/interfaces are safe to remove? They are marked deprecated and use V1 embedding classes.
GaryQian
force-pushed
the
deprecatev1
branch
2 times, most recently
from
630c9c6 to
94ace52
Compare
GaryQian
changed the title
|
This is now passing engine presubmit. We can now attempt to land this and experiment with rolling to framework. We should also verify all the files removed here are safe to remove. |
|
Are the presubmit failures related? What checks have you done locally to give confidence that rolling to the framework will be successful? |
|
The presubmit here is now passing (minor docs issue). Im currently running through as many of the pre and postsubmit checks as I can locally. Some will need to be staged for real to run though. So far, things are passing for the most part, though there are one or two failures in some example apps I'll address before continuing. |
|
I'll likely land and then immediately revert this just to have an engine commit I can experiment with rolling to. |
|
I have reasonable confidence in this not being too bad from local testing, will attempt an experimental landing+draft roll+revert later tonight after workday is over to avoid disruption. |
disable formatting Fix imports Licenses Fix tests
Fix imports Clean manifest" Clean io.flutter.app references
|
Mac unopt passes: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Unopt/5318/overview failure is a flake. Landing, will revert after a postsubmit build run completes. |
Work in progress
cc @camsim99 @blasten