This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Delete io.flutter.app android v1 embedding" #32232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e514a5.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
GaryQian
added
the
waiting for tree to go green
zanderso
approved these changes
Mar 24, 2022
GaryQian
added a commit
to GaryQian/engine
that referenced
this pull request
Mar 24, 2022
This reverts commit 0522b48.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2022
* 2e514a5 Delete io.flutter.app android v1 embedding (flutter/engine#32074) * 7d93d6b Roll Skia from 9aa9c14ffdae to 91b860c5fde4 (1 revision) (flutter/engine#32231) * 0522b48 Revert "Delete io.flutter.app android v1 embedding" (flutter/engine#32232) * 6d833f8 Roll Skia from 91b860c5fde4 to fd96fb27a906 (1 revision) (flutter/engine#32233) * 2646539 Roll Fuchsia Linux SDK from oTjwOwAoJ... to _2DtWbNRj... (flutter/engine#32234) * d113a11 Roll Fuchsia Mac SDK from 4MoGGSDPk... to QLxrAkriN... (flutter/engine#32237) * 126a156 Roll Skia from fd96fb27a906 to 4ccb0ddcc4eb (1 revision) (flutter/engine#32238)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #32074, Failing framework multidex tests. Will reland after fixing.