start work on a testing plan for devtools #5
Conversation
|
Plan LGTM (though sounds like you're not ready to merge if you're going to add a test). |
|
Yup, I'd like to try and get one test in, then iterate on that - add one or two more, and make sure that the common parts of the tests are abstracted out a bit (build the framework once we have a better idea of what the tests will look like). |
|
OK, this PR now contains the integration testing framework and the first two integration tests. test 1: start the devtools app and verify that you can switch pages Ready for review; comments welcome. After landing, I'll follow up with a PR that runs the tests on travis (they just run via |
test/fixtures/logging_app.dart
Outdated
|
|
||
| void main() { | ||
| log('starting app'); | ||
| print('starting app'); |
There was a problem hiding this comment.
can the print calls be removed?
There was a problem hiding this comment.
I'd like to keep them just for the sake of making it easier to debug this app in some circumstances.
test/src/chrome.dart
Outdated
|
|
||
| //const String defaultPath = '/Applications/Google Chrome.app'; | ||
| const String defaultPath = '/Applications/Google Chrome Canary.app'; | ||
| //const String bundlePath = 'Contents/MacOS/Google Chrome'; |
There was a problem hiding this comment.
I assume you meant to leave it at Chrome not Canary before checkin?
test/src/chrome.dart
Outdated
| WipConnection get wipConnection => _wip; | ||
| } | ||
|
|
||
| // TODO(devoncarew): I'm not sure this class is necessary. |
There was a problem hiding this comment.
probably remove this class.
A rough draft of a testing plan for this project. I'd expect to use
package:testto write tests, and each test would have the setup described in the markdown file. Comments welcome, and I'll work on adding an actual test as part of this PR.@jacob314 @DanTup