Memory > Diff: UX improvements. #5015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/screens/memory/panes/diff/diff_pane.dart
Outdated
Show resolved
Hide resolved
Comment on lines
241
to
244
| _columnStore.putIfAbsent( | ||
| '${identityHashCode(classFilterButton)}', | ||
| () => _ClassesTableDiffColumns(classFilterButton), | ||
| ); |
There was a problem hiding this comment.
this is confusing. Why do we have a column store where we store a set of columns based on a widget's hash code?
packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/snapshot_list.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/memory/allocation_tracing/allocation_profile_tracing_view_test.dart
Outdated
Show resolved
Hide resolved
CoderDake
reviewed
Jan 9, 2023
CoderDake
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move class filter from control pane to column header to make it discoverable (see session 5 in go/devtools-memory-diff-ux-research)
Update diff guidance to require understanding of memory concepts
Move word 'snapshot' from documentation item to tab header
Add noun to each tab header to make them more verbose:
Screen.Recording.2023-01-08.at.8.15.11.AM.mov