Fix release workflow #146
Open
Fix release workflow #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lehman Garrison <lgarrison@flatironinstitute.org>
|
@lgarrison let me know what you think! I have some other cleanups that I wouldn't mind doing before we try releasing again. Let me see if I can wrap them up this weekend. If not, please feel free to release again. (Note: I normally do a |
lgarrison
reviewed
Jun 8, 2025
Comment on lines
-49
to
+48
| before-all = "brew install fftw" | ||
| before-all = "brew install llvm libomp" |
There was a problem hiding this comment.
If we aren't going to try to target older MACOSX_DEPLOYMENT_TARGET, then I think we can just brew-install fftw. Trying to support old targets was the reason I removed this. (Likewise, all the CC=... environment variable setup below may not be necessary anymore, but it probably doesn't hurt either.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes from #145
I've killed the x86 mac build as suggested by @lgarrison over in #145, and manually confirmed that the ARM mac wheels are working properly.