fix wheel/sdist build #145
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release pipeline is all kinds of broken! Both sdist and wheel builds are failing.
The sdist fix should be a quick one. The wheel build is failing on MacOS with a delocation error:
I think this is because we're brew-installing fftw, which is installing it for the current runner (macos-14) rather than the target platform (11.0). cibuildwheel mentions this pitfall: https://cibuildwheel.pypa.io/en/stable/faq/#macos-library-dependencies-do-not-satisfy-target-macos
finufft is now smart enough to fetch and build its own fftw through CPM, so if we're lucky, simply removing the brew install will be enough to fix this.