Tags: flashlight/text
Tags
Fix source distribution build and upgrade CI baselines (#83) Summary: Source distributions never had the right version file -- they'd always fail. `bindings/python/.../version.py` is always written out when building an sdist, so try to use it if it's available. Add a CI baseline to try using the sdist/install with KenLM Also move to Jammy for baseline Linux images since most Focal ones are being deprecate and upgrade GHA components depending on old Node versions. v4 of these actions breaks artifact storage with dup names/doesn't merge automatically; fix this. Contents of `dist` post-upload by wheel builder/sdist becomes ``` -rw-r--r-- 1 runner docker 60364 Feb 28 18:47 flashlight-text-0.0.6.dev336.tar.gz -rw-r--r-- 1 runner docker 10395[8](https://github.com/flashlight/text/actions/runs/8085500728/job/22093301914#step:3:9)5 Feb 28 18:47 flashlight_text-0.0.6.dev336-cp312-cp312-macosx_10_[9](https://github.com/flashlight/text/actions/runs/8085500728/job/22093301914#step:3:10)_x86_64.whl -rw-r--r-- 1 runner docker 1304785 Feb 28 18:47 flashlight_text-0.0.6.dev336-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl -rw-r--r-- 1 runner docker 1683721 Feb 28 18:47 flashlight_text-0.0.6.dev336-cp312-cp312-musllinux_1_1_x86_64.whl -rw-r--r-- 1 runner docker 496932 Feb 28 18:47 flashlight_text-0.0.6.dev336-cp312-cp312-win_amd64.whl ``` ### Test Plan (required) CI + local test ```bash pipx run build --sdist # move tarball out of git repo where commands to fetch hashes failed cd ${SOURCE_DIST_DIR} # after untarring USE_KENLM=0 pip install -v . ``` ### Checklist - [x] Test coverage - [x] Tests pass - [x] Code formatted - [x] Rebased on latest matter - [x] Code documented Pull Request resolved: #83 Reviewed By: bwasti Differential Revision: D54318442 Pulled By: jacobkahn fbshipit-source-id: a63d5af096178eee83049120a6248bb1bbc698a8
Explicitly export library symbols (#70) Summary: Explicitly export symbols with visibility to avoid using the bad `WINDOWS_EXPORT_ALL_SYMBOLS` option. Pull Request resolved: #70 Test Plan: CI, local test ### Checklist - [x] Test coverage - [x] Tests pass - [x] Code formatted - [x] Rebased on latest matter - [x] Code documented Reviewed By: mthrok Differential Revision: D46530422 Pulled By: jacobkahn fbshipit-source-id: cb730f09024c9760dc00b35e184185be0cf60922
Build Linux and macOS arm64 wheels in CircleCI (#62) Summary: See title. Build wheels in new platforms (and without self-runners). Add Linux arm64 wheels. Pull Request resolved: #62 Test Plan: CI Reviewed By: mostafaelhoushi Differential Revision: D44654274 Pulled By: jacobkahn fbshipit-source-id: d14378317ca61945b687a2bf7273d11b5df9d925
Ensure CMake uses the correct executable per cibuildwheel (#48) Summary: See title. Using `FindPython3` in CMake >= 3.16 requires using `PYTHON3_EXECUTABLE` as the relevant flag specifying the interpreter path. This ensures that headers and modules are found in the proper subtree by CMake such that bindings are linked against the correct version of Python. Current Wheel builds link against totally spurious versions. Pull Request resolved: #48 Test Plan: CI + CIBW, ensuring that the correct CIBW version of Python is what CMake finds at wheel build time. Reviewed By: ArmenAg Differential Revision: D43430086 Pulled By: jacobkahn fbshipit-source-id: 40b5fca1abd7ca2c5ec3686272cb707b7726d0df