Explicitly export library symbols #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Explicitly export symbols with visibility to avoid using the bad `WINDOWS_EXPORT_ALL_SYMBOLS` option. Pull Request resolved: flashlight#70 Test Plan: CI, local test ### Checklist - [x] Test coverage - [x] Tests pass - [x] Code formatted - [x] Rebased on latest matter - [x] Code documented Reviewed By: mthrok Differential Revision: D46530422 Pulled By: jacobkahn fbshipit-source-id: f35c3911365c8063e86da7704abeb9abff5b4819
|
This pull request was exported from Phabricator. Differential Revision: D46530422 |
11 tasks
|
@jacobkahn merged this pull request in 22e2ba0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly export symbols with visibility to avoid using the bad
WINDOWS_EXPORT_ALL_SYMBOLSoption.Test plan: CI, local test
Checklist