Ensure CMake uses the correct executable per cibuildwheel #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jacobkahn merged this pull request in 07e5673. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. Using
FindPython3in CMake >= 3.16 requires usingPYTHON3_EXECUTABLEas the relevant flag specifying the interpreter path. This ensures that headers and modules are found in the proper subtree by CMake such that bindings are linked against the correct version of Python. Current Wheel builds link against totally spurious versions.Test plan: CI + CIBW, ensuring that the correct CIBW version of Python is what CMake finds at wheel build time.