Skip to content

Fix: Fixed issue with open terminal as admin not working #11444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix: Fixed issue with open terminal as admin not working #11444

merged 2 commits into from
Feb 23, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

yaira2
yaira2 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you get a chance, can you convert this to use the new rich commands?

@yaira2 yaira2 changed the title Fixed: Open terminal as admin shortcut not working Fix: Fixed issue with open terminal as admin not working Feb 23, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 23, 2023
@yaira2 yaira2 merged commit b9192b5 into files-community:main Feb 23, 2023
@ferrariofilippo ferrariofilippo deleted the Shell_Page_Refactoring_Leftovers branch February 23, 2023 21:51
@ferrariofilippo
Copy link
Contributor Author

If you get a chance, can you convert this to use the new rich commands?

We may use that to add Open in terminal to context menu

@yaira2
Copy link
Member

yaira2 commented Feb 23, 2023

Let's start with the shortcut, it should already be shown in the context menu because of the shell extension.

@ferrariofilippo ferrariofilippo mentioned this pull request Mar 11, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTRL+SHIFT+` for admin terminal on current working directory is not working
2 participants
@ferrariofilippo @yaira2