Skip to content

Feature: Added shortcut to open Windows Terminal as administrator #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2023
Merged

Feature: Added shortcut to open Windows Terminal as administrator #11281

merged 7 commits into from
Feb 14, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Feb 13, 2023 •
edited by yaira2
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Notes

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

yaira2
yaira2 previously approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Open Windows Terminal as Admin Feature: Added shortcut to open Windows Terminal as Admin Feb 13, 2023
@yaira2 yaira2 changed the title Feature: Added shortcut to open Windows Terminal as Admin Feature: Added shortcut to open Windows Terminal as administrator Feb 13, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 13, 2023

Instead of requiring Files to be admin, can display a UAC prompt?

@yaira2 yaira2 self-requested a review February 14, 2023 04:55
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Feb 14, 2023
@ferrariofilippo
Copy link
Contributor Author

There's a bug with latest commit, I'll try to figure out why

yaira2
yaira2 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you add to the documentation?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Feb 14, 2023
@yaira2 yaira2 merged commit e3eaf9d into files-community:main Feb 14, 2023
@yaira2 yaira2 changed the title Feature: Added shortcut to open Windows Terminal as administrator Feature: Added shortcut to open Windows Terminal as administrator Feb 14, 2023
@ferrariofilippo ferrariofilippo deleted the Open_Terminal branch February 14, 2023 19:46
francisco-lafe
francisco-lafe reviewed Feb 23, 2023
View reviewed changes
@ferrariofilippo ferrariofilippo mentioned this pull request Feb 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisco-lafe francisco-lafe francisco-lafe left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Open Windows Terminal as admin using ctrl + shift + `
3 participants
@ferrariofilippo @yaira2 @francisco-lafe