Skip to content

Feature: Removed FullTrustProcess #10283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Oct 30, 2022
Merged

Feature: Removed FullTrustProcess #10283

merged 54 commits into from
Oct 30, 2022

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Oct 23, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@lukeblevins lukeblevins changed the title Dev/lubl/trashhandler misc FullTrustProcess removal Oct 23, 2022
@lukeblevins lukeblevins changed the title misc FullTrustProcess removal Feature: misc FullTrustProcess removal Oct 23, 2022
@lukeblevins lukeblevins changed the title Feature: misc FullTrustProcess removal Feature: Miscellaneous FullTrustProcess removal Oct 24, 2022
@lukeblevins lukeblevins mentioned this pull request Oct 25, 2022
Closed
20 tasks
hez2010
hez2010 reviewed Oct 26, 2022
View reviewed changes
@lukeblevins lukeblevins marked this pull request as ready for review October 26, 2022 19:27
@lukeblevins lukeblevins changed the title Feature: Miscellaneous FullTrustProcess removal Feature: FullTrustProcess removal Oct 26, 2022
@mdtauk
Copy link
Contributor

mdtauk commented Oct 26, 2022

LOL I was just talking about how Files made use of FullTrust on a live stream with the guy who added FullTrust for UWP on Windows - Is this the move to Win32 code with WinUI 3?

@yaira2 yaira2 changed the title Feature: FullTrustProcess removal Feature: Removed FullTrustProcess and switched to single project msix Oct 26, 2022
@lukeblevins
Copy link
Contributor Author

LOL I was just talking about how Files made use of FullTrust on a live stream with the guy who added FullTrust for UWP on Windows - Is this the move to Win32 code with WinUI 3?

@mdtauk You can use a WASDK version of Files today with the Preview version. We're just doing the hard work now to adapt to and make full use of the new app model.

Notably, removing the FullTrust process reduces latency and memory usage for free. In our case, using APIs that weren't available before will offer even more incremental benefits in the coming months.

The org now recognizes code quality and optimizations as an area that can deliver measurable value for both users and contributors.

hez2010
hez2010 reviewed Oct 27, 2022
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Oct 27, 2022 •
edited
Loading

It's been noted that msixbundles can't be generated for single projects. We can either find a way to build the different architectures and then bundle them together or alternatively, we can restore the packaging project for the time being.
I think the second option makes most sense as it'll allow us to take advantage of these improvements without spending time on this issue.

hez2010
hez2010 previously approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the build pipeline is green now. @yaichenbaum to test the release pipeline.

@hez2010 hez2010 mentioned this pull request Oct 29, 2022
Merged
2 tasks
yaira2
yaira2 previously approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major milestone for Files!
LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 30, 2022
@yaira2 yaira2 merged commit 5340097 into files-community:main Oct 30, 2022
@cinqmilleans cinqmilleans mentioned this pull request Oct 30, 2022
Merged
2 tasks
@lukeblevins lukeblevins deleted the dev/lubl/trashhandler branch March 26, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hez2010 hez2010 hez2010 left review comments

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Remove FullTrust handlers
5 participants
@lukeblevins @mdtauk @yaira2 @hez2010 @itsWindows11