Feature: Removed FullTrustProcess (#10283)

Author: lukeblevins

.gitignore

@@ -57,7 +57,6 @@ BenchmarkDotNet.Artifacts/
 project.lock.json
 project.fragment.lock.json
 artifacts/
-**/Properties/launchSettings.json
 
 # StyleCop
 StyleCopReport.xml
@@ -174,7 +173,6 @@ publish/
 *.azurePubxml
 # Note: Comment the next line if you want to checkin your web deploy settings,
 # but database connection strings (with potential passwords) will be unencrypted
-*.pubxml
 *.publishproj
 
 # Microsoft Azure Web App publish settings. Comment the next line if you want to

Directory.Build.props

@@ -56,12 +56,12 @@ jobs:
     inputs:
       targetType: 'inline'
       script: |
-        [xml]$xmlDoc = Get-Content $(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest
+        [xml]$xmlDoc = Get-Content '$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest'
         $xmlDoc.Package.Identity.Name="${{parameters.packageIdentityName}}"
         $xmlDoc.Package.Identity.Publisher="Files"
         $xmlDoc.Package.Properties.DisplayName="${{parameters.packageDisplayName}}"
         $xmlDoc.Package.Applications.Application.VisualElements.DisplayName="${{parameters.packageDisplayName}}"
-        $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest')
+        $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest')
       failOnStderr: true
 
  # This replaces references to the dev icon with the specified icon variant 
@@ -114,13 +114,13 @@ jobs:
       script: |
         for /f %%a in ('dir /b /a:d %localappdata%\Microsoft\VisualStudio\17*') do echo UsePreviews=True>%localappdata%\Microsoft\VisualStudio\%%a\sdk.txt
 
-  - task: NuGetToolInstaller@1
-
-  - task: NuGetCommand@2
+  - task: MSBuild@1
     inputs:
-      feedsToUse: config
-      nugetConfigPath: nuget.config
-      restoreSolution: '$(solution)'
+      platform: 'x64'
+      solution: '$(solution)'
+      configuration: '$(sideloadBuildConfiguration)'
+      msbuildArguments: '/t:restore /p:Configuration="$(sideloadBuildConfiguration)";Platform="$(buildPlatform)";PublishReadyToRun=true'
+      maximumCpuCount: true
 
   - task: DownloadSecureFile@1
     name: caCertificate
@@ -168,20 +168,18 @@ jobs:
     inputs:
       targetType: 'inline'
       script: |
-        [xml]$xmlDoc = Get-Content $(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest
+        [xml]$xmlDoc = Get-Content '$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest'
         $xmlDoc.Package.Identity.Name="49306atecsolution.FilesUWP"
         $xmlDoc.Package.Identity.Publisher="CN=53EC4384-7F5B-4CF6-8C23-513FFE9D1AB7"
         $xmlDoc.Package.Properties.DisplayName="Files"
         $xmlDoc.Package.Applications.Application.VisualElements.DisplayName="Files"
-
         # Removes packageManagement from Store release
         $nsmgr = New-Object System.Xml.XmlNamespaceManager($xmlDoc.NameTable)
         $nsmgr.AddNamespace("pkg", "http://schemas.microsoft.com/appx/manifest/foundation/windows10")
         $nsmgr.AddNamespace("rescap", "http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities")
         $pm = $xmlDoc.SelectSingleNode("/pkg:Package/pkg:Capabilities/rescap:Capability[@Name='packageManagement']", $nsmgr)
         $xmlDoc.Package.Capabilities.RemoveChild($pm)
-
-        $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest')
+        $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest')
       failOnStderr: true
 
  # This replaces references to the dev icon with the specified icon variant 
@@ -234,13 +232,13 @@ jobs:
       script: |
         for /f %%a in ('dir /b /a:d %localappdata%\Microsoft\VisualStudio\17*') do echo UsePreviews=True>%localappdata%\Microsoft\VisualStudio\%%a\sdk.txt
 
-  - task: NuGetToolInstaller@1
-
-  - task: NuGetCommand@2
+  - task: MSBuild@1
     inputs:
-      feedsToUse: config
-      nugetConfigPath: nuget.config
-      restoreSolution: '$(solution)'
+      platform: 'x64'
+      solution: '$(solution)'
+      configuration: '$(buildConfiguration)'
+      msbuildArguments: '/t:restore /p:Configuration="$(buildConfiguration)";Platform="$(buildPlatform)";PublishReadyToRun=true'
+      maximumCpuCount: true
 
   - task: MSBuild@1
     inputs:
@@ -249,7 +247,7 @@ jobs:
       configuration: '$(buildConfiguration)'
       msbuildArguments: '/t:build;_GenerateAppxPackage /p:AppxBundlePlatforms="$(buildPlatform)" /p:AppxPackageDir="$(appxPackageDir)" /p:AppxBundle=Always /p:UapAppxPackageBuildMode=StoreUpload'
       maximumCpuCount: true
-    
+
   - task: CopyFiles@2
     displayName: 'Copy Files to: $(build.artifactstagingdirectory)'
     inputs:
@@ -274,4 +272,4 @@ jobs:
       skipPolling: false
       deletePackages: true
       numberOfPackagesToKeep: '5'
-      isMandatoryUpdate: true
+      isMandatoryUpdate: true

Files.sln

@@ -15,12 +15,12 @@ steps:
   inputs:
     targetType: 'inline'
     script: |
-      [xml]$xmlDoc = Get-Content $(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest
+      [xml]$xmlDoc = Get-Content '$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest'
       $xmlDoc.Package.Identity.Name="49306atecsolution.FilesUWP"
       $xmlDoc.Package.Identity.Publisher="CN=53EC4384-7F5B-4CF6-8C23-513FFE9D1AB7"
       $xmlDoc.Package.Properties.DisplayName="Files"
       $xmlDoc.Package.Applications.Application.VisualElements.DisplayName="Files"
-      $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.Package\Package.appxmanifest')
+      $xmlDoc.Save('$(Build.SourcesDirectory)\src\Files.App (Package)\Package.appxmanifest')
     failOnStderr: true
 
 - task: PowerShell@2
@@ -70,13 +70,13 @@ steps:
     script: |
       for /f %%a in ('dir /b /a:d %localappdata%\Microsoft\VisualStudio\17*') do echo UsePreviews=True>%localappdata%\Microsoft\VisualStudio\%%a\sdk.txt
 
-- task: NuGetToolInstaller@1
-
-- task: NuGetCommand@2
+- task: MSBuild@1
   inputs:
-    feedsToUse: config
-    nugetConfigPath: nuget.config
-    restoreSolution: '$(solution)'
+    platform: 'x64'
+    solution: '**/*.sln'
+    configuration: '$(buildConfiguration)'
+    msbuildArguments: '/t:restore /p:Configuration=Debug;Platform="$(buildPlatform)";PublishReadyToRun=true'
+    maximumCpuCount: true
 
 - task: MSBuild@1
   inputs:
@@ -117,7 +117,7 @@ steps:
 #  inputs:
 #    testSelector: 'testAssemblies'
 #    testAssemblyVer2: |
-#      **\$(buildConfiguration)\Files.InteractionTests\net6.0\Files.InteractionTests.dll
+#      **\$(buildConfiguration)\Files.InteractionTests\net7.0\Files.InteractionTests.dll
 #      !**\*TestAdapter.dll
 #      !**\obj\**
 #    searchFolder: '$(System.DefaultWorkingDirectory)'
@@ -132,4 +132,4 @@ steps:
 - task: PublishBuildArtifacts@1
   displayName: 'Publish Artifact: drop'
   inputs:
-    PathtoPublish: '$(build.artifactstagingdirectory)'
+    PathtoPublish: '$(build.artifactstagingdirectory)'

builds/azure-pipelines-release.yml

@@ -2,6 +2,6 @@
 <configuration>
     <packageSources>
         <add key="NuGet official package source" value="https://api.nuget.org/v3/index.json" />
-        <add key="Local Packages" value="src\Files.Package\nupkgs\" />
+        <add key="Local Packages" value="src\Files.App\nupkgs\" />
     </packageSources>
 </configuration>

builds/azure-pipelines.yml

@@ -1,82 +1,20 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>net7.0-windows10.0.22000.0</TargetFramework>
-    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
-    <Platform Condition=" '$(Platform)' == '' ">x86</Platform>
-    <Platforms>x86;x64;arm64</Platforms>
-    <RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers>
     <AssemblyName>BackgroundTasks</AssemblyName>
     <DefaultLanguage>en-US</DefaultLanguage>
     <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
     <IsTrimmable>true</IsTrimmable>
+    <Configurations>Debug;Release;Sideload</Configurations>
+    <Platforms>x86;x64;ARM64</Platforms>
+    <RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>
   </PropertyGroup>
   <PropertyGroup>
     <CsWinRTComponent>true</CsWinRTComponent>
     <CsWinRTWindowsMetadata>10.0.22000.0</CsWinRTWindowsMetadata>
     <CsWinRTGeneratedFilesDir>$(MSBuildProjectDirectory)\bin\$(Platform)\$(Configuration)</CsWinRTGeneratedFilesDir>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.Windows.CsWinRT">
-      <Version>2.0.0</Version>
-    </PackageReference>
+    <PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.0" />
   </ItemGroup>
-  <ItemGroup>
-    <None Update="WinRT.Host.runtimeconfig.json">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
-  </ItemGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
-    <PlatformTarget>x86</PlatformTarget>
-    <DefineConstants>DEBUG;TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x86'">
-    <PlatformTarget>x86</PlatformTarget>
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|arm64'">
-    <PlatformTarget>arm64</PlatformTarget>
-    <DefineConstants>DEBUG;TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|arm64'">
-    <PlatformTarget>arm64</PlatformTarget>
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'">
-    <PlatformTarget>x64</PlatformTarget>
-    <DefineConstants>DEBUG;TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
-    <PlatformTarget>x64</PlatformTarget>
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Sideload|x86'">
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <PlatformTarget>x86</PlatformTarget>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Sideload|arm64'">
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <PlatformTarget>arm64</PlatformTarget>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Sideload|x64'">
-    <DefineConstants>TRACE;NETFX_CORE</DefineConstants>
-    <NoWarn>;2008</NoWarn>
-    <PlatformTarget>x64</PlatformTarget>
-    <UseVSHostingProcess>false</UseVSHostingProcess>
-  </PropertyGroup>
 </Project>