Skip to content

Feature: Optimize startup speed #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Feature: Optimize startup speed #10322

merged 1 commit into from
Oct 30, 2022

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Oct 29, 2022 •
edited
Loading

  • Initialize logger and components in the background
  • Remove unnecessary async
  • Activate the Window early and postpone activation arguments parsing

Suggestion: merge both #10283 and this PR to see the startup performance boost.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

QuaintMako
QuaintMako reviewed Oct 29, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, but not a specialist of async. Another look may be beneficial.

@QuaintMako
Copy link
Contributor

Related to #4180.

@yaira2 yaira2 changed the title Optimize startup speed Feature: Optimize startup speed Oct 30, 2022
yaira2
yaira2 approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 30, 2022
@yaira2 yaira2 merged commit a2958d1 into main Oct 30, 2022
@yaira2 yaira2 deleted the startup branch October 30, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuaintMako QuaintMako QuaintMako left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hez2010 @QuaintMako @yaira2