Add graphql subscriptions and mutations #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2021
Merged
nonsense
reviewed
Nov 9, 2021
| http.Handle("/graphql", &corsHandler{graphQLHandler}) | ||
| go func() { | ||
| listenAddr := fmt.Sprintf(":%d", httpPort) | ||
| fmt.Printf("Graphql server listening on %s\n", listenAddr) |
There was a problem hiding this comment.
Nit, but I think we should default to using log instead of fmt.Print as much as we can. (also this is helpful because it has the listenAddr)
nonsense
approved these changes
Nov 9, 2021
* feat: implement dummy deal API * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * feat: add react subscription / mutations (#23) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
dirkmc
added a commit
that referenced
this pull request
Nov 10, 2021
* feat: grapql subscriptions and mutations * Implement dummy deal API (#22) * feat: implement dummy deal API * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * feat: add react subscription / mutations (#23) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
dirkmc
added a commit
that referenced
this pull request
Nov 10, 2021
* refactor: storage provider * refactor: pass deal state as parameter instead of having its own struct (#25) * Add graphql subscriptions and mutations (#21) * feat: grapql subscriptions and mutations * Implement dummy deal API (#22) * feat: implement dummy deal API * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * feat: add react subscription / mutations (#23) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #20