Refactor storage provider #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
refactor/provider
branch
from
9711d11 to
0b9f32e
Compare
This was referenced Nov 5, 2021
* feat: grapql subscriptions and mutations * Implement dummy deal API (#22) * feat: implement dummy deal API * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * Update node/impl/boost.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * feat: add react subscription / mutations (#23) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
dirkmc
force-pushed
the
refactor/provider
branch
from
327b3b2 to
8e4ec0d
Compare
nonsense
reviewed
Nov 10, 2021
Comment on lines
+92
to
+94
| acceptDealsChan: make(chan acceptDealReq, 128), | ||
| failedDealsChan: make(chan failedDealReq, 128), | ||
| restartDealsChan: make(chan restartReq, 128), |
There was a problem hiding this comment.
@dirkmc @aarshkshah1992 i think this is dangerous - if we have a bug in our code, we won't notice a deadlock, until we hit 128 deals... this channel should be unbuffered IMO as a start... also why 128 and not 1 or 10 or 20?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a struct to keep track of deal execution (instead of passing around parameters)
Depends on #19