Translate from DB to objects #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Offset INT, | ||
| Length INT, | ||
| Checkpoint TEXT, | ||
| Error TEXT, |
There was a problem hiding this comment.
Dirk, my experience has been that persisting errors to DB never works out well, especially when there's resumption involved. Can we get rid of this and add it back only if we absolutely need it ?
There was a problem hiding this comment.
We have a checkpoint value called "Complete" but we don't have a way to distinguish between "Completed successfully" and "Completed with error". I'm open to suggestions here.
| } | ||
|
|
||
| // TODO: use a generic data transfer descriptor instead of a URL | ||
| u := url.URL{} |
There was a problem hiding this comment.
Yeah, this should change to the opaque transfer descriptor byte token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This doesn't compile, as some of the changes are made in the other open PRs: #20 #21 #22 #23
I separated out the PRs to try to make it easier to review them instead of having a single giant PR.