-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kubernetes >= 1.16 #1044
Support for Kubernetes >= 1.16 #1044
Conversation
Welcome @maxgio92! It looks like this is your first PR to falcosecurity/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This was annoying me also.
LGTM label has been added. Git tree hash: df61ca37e4037f2f0fcd25c5e6d9d97692b6b407
|
/hold The more I think about this the more I think we need to have this new chart in a different directory so that we can support both |
Thanks @kris-nova. Are you referrring to Kubernetes >= 1.16 and Kubernetes < 1.16? |
/milestone 0.21.0 |
Let me remove this from the milestone until we don't have a clear idea of how we want to do those. Also the |
@kris-nova do you want to hold this still? We might just ask @maxgio92 to create a different directory for this? |
The change was already merged in the helm chart helm/charts#17339 |
@leogr this is the PR I was mentioning to you before |
Just an idea: we could automate this by using the helm chart to locally render the templates for each supported configuration. @leodido @fntlnz WDYT? |
I think we can merge this and then have a discussion on how/where to keep manifests for old Kubernetes versions. Also from the release announcement:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maxgio92 we decided to merge this as soon the last changes requested by me and @fntlnz are committed.
In particular, this PR must also include the changes to replace deployment extensions/v1beta1
to apps/v1
integrations/k8s-using-deployment/k8s-with-rbac/falco-k8s-audit-deployment.yaml
1:apiVersion: extensions/v1beta1
integrations/k8s-using-deployment/falco-event-generator-deployment.yaml
1:apiVersion: extensions/v1beta1
Finally, we'd like help in maintaining these files (maybe for different K8S versions too). In case you're interested in helping us with this topic please join the next community call to make a plan together! :)
update API resource version and remove deprecated one. Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
update API resource version and remove deprecated one. Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
…version replace extension/v1beta1 with 1.16-supported apps/v1 version as for release announcement BREAKING CHANGE: spec.rollbackTo is removed, spec.selector is now required and immutable after creation, spec.progressDeadlineSeconds now defaults to 600 seconds, spec.revisionHistoryLimit now defaults to 10, maxSurge and maxUnavailable now default to 25% issue #1043 Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
replace rbac.authorization.k8s.io/v1beta1 with rbac.authorization.k8s.io/v1 as for the changelog Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
PS: I think that it depends on the level of automation in the whole project, but as for the installation steps other than Helm charts Kustomizations could be a starting point, with overlays for each main "breaking version", as it is integrated and minimal :) |
LGTM label has been added. Git tree hash: 816f9ae80c2477ff3183138bdb08264d63749a3a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we can now merge this, then 👉 #1145
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area kubernetes
What this PR does / why we need it:
Support for Kubernetes 1.16 and 1.17 when deployed as DaemonSet.
Which issue(s) this PR fixes:
Fixes #1043
Fixes #993
Special notes for your reviewer:
Removed deprecated Kubernetes 1.16 API resource versions.
Affected API:
Documentation:
Does this PR introduce a user-facing change?:
NONE
Release note