Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/falco] migrate API versions from deprecated, removed versions #17339

Merged
merged 1 commit into from
Nov 25, 2019
Merged

[stable/falco] migrate API versions from deprecated, removed versions #17339

merged 1 commit into from
Nov 25, 2019

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Sep 22, 2019

Signed-off-by: Naoki Oketani okepy.naoki@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

NO

What this PR does / why we need it:

In k8s v1.16 some APIs are deprecated and removed.
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

As a result, installation failed. I migrate to use supported API versions.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@k8s-ci-robot k8s-ci-robot requested a review from bencer September 22, 2019 01:59
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @oke-py. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2019
@oke-py
Copy link
Contributor Author

oke-py commented Sep 22, 2019

/assign @nestorsalceda

nestorsalceda
nestorsalceda suggested changes Oct 7, 2019
View reviewed changes
stable/falco/CHANGELOG.md Outdated

### Minor Changes

* migrate API versions from deprecated, removed versions to support Kubernetes v1.16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize migrate word

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nestorsalceda I fixed it.

@oke-py
Copy link
Contributor Author

oke-py commented Oct 7, 2019

There are 2 conflicting files.
Should I update chart version to 1.0.9?

@oke-py
Copy link
Contributor Author

oke-py commented Oct 7, 2019

rebased and force pushed

@zanhsieh
Copy link
Collaborator

zanhsieh commented Oct 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2019
@oke-py
[stable/falco] migrate API versions from deprecated, removed versions
b492111 
Signed-off-by: Naoki Oketani <okepy.naoki@gmail.com>
@oke-py
Copy link
Contributor Author

oke-py commented Oct 12, 2019

@nestorsalceda @zanhsieh There are some conflict. I rebased, resolved conflict, and force-pushed. PTAL. Thanks in advance.

@oke-py oke-py requested a review from nestorsalceda October 12, 2019 11:48
@oke-py
Copy link
Contributor Author

oke-py commented Nov 7, 2019

@nestorsalceda Hi, could you review this PR again?

@mfdii
Copy link

mfdii commented Nov 25, 2019

@nestorsalceda would you review for @frankreno

@nestorsalceda
Copy link
Collaborator

/lgtm

Thanks for your contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nestorsalceda, oke-py

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit d874c50 into helm:master Nov 25, 2019
@oke-py oke-py deleted the falco branch November 25, 2019 23:35
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@oke-py
[stable/falco] migrate API versions from deprecated, removed versions (…
2982932 
…helm#17339)

Signed-off-by: Naoki Oketani <okepy.naoki@gmail.com>
Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@oke-py
[stable/falco] migrate API versions from deprecated, removed versions (…
73d92cc 
…helm#17339)

Signed-off-by: Naoki Oketani <okepy.naoki@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@oke-py @dargolith
[stable/falco] migrate API versions from deprecated, removed versions (…
c9a815f 
…helm#17339)

Signed-off-by: Naoki Oketani <okepy.naoki@gmail.com>
This was referenced Mar 8, 2020
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bencer bencer Awaiting requested review from bencer

@nestorsalceda nestorsalceda Awaiting requested review from nestorsalceda

Assignees

@nestorsalceda nestorsalceda

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/falco] deprecated APIs removed in k8s 1.16
6 participants
@oke-py @k8s-ci-robot @zanhsieh @mfdii @nestorsalceda @helm-bot