Modifying apiVersion for daemonset and adding selectors

[rushabh268]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area integrations

What this PR does / why we need it:

This PR fixes the case where Falco daemonset cannot be deployed in Kubernetes 1.17+ due to incorrect apiVersion and missing selector for pods

Which issue(s) this PR fixes:

#993

Automatically closes linked issue when PR is merged.
Usage: Fixes #993.

Fixes #993

Special notes for your reviewer:

This should fix the following errors:

root@int:~/falco/integrations/k8s-using-daemonset# kubectl apply -f k8s-with-rbac/falco-config/falco-daemonset-configmap.yaml
error: unable to recognize "k8s-with-rbac/falco-config/falco-daemonset-configmap.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"

root@int:~/falco/integrations/k8s-using-daemonset# kubectl apply -f k8s-with-rbac/falco-config/falco-daemonset-configmap.yaml
error: error validating "k8s-with-rbac/falco-config/falco-daemonset-configmap.yaml": error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false

Does this PR introduce a user-facing change?:

NONE

[poiana]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mstemm
You can assign the PR to them by writing /assign @mstemm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[poiana]

Welcome @rushabh268! It looks like this is your first PR to falcosecurity/falco 🎉

[rushabh268]

/assign @mstemm

[fntlnz]

Hi @rushabh268 - thanks for fixing this! Can you please address my comment and do the same in falco-daemonset-configmap-slim.yaml and in k8s-without-rbac/falco-service.yaml ?

[fntlnz]

Also @rushabh268 please sign-off your commit.
You can do that by adding -s when you do a commit:

E.g:

git commit -sm "your message"

or if you want to sign the last commit you did:

git commit -s --amend --no-edit

[rushabh268]

@fntlnz I have made the suggested changes and also made the necessary changes to integrations/k8s-using-daemonset/falco-event-generator-deployment.yaml. I have also signed off the last commit.

[leodido]

Hey @rushabh268 thanks for doing this!

Any chance you can also do it for falco-daemonset-configmap-slim.yaml and k8s-without-rbac/falco-service.yaml ? :)

[rushabh268]

@leodido I think I made those changes here: 3e6e22b

[leodido]

/check-dco

[poiana]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• 73129e1 Update integrations/k8s-using-daemonset/k8s-with-rbac/falco-daemonset-configmap.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[leodido]

/milestone 0.21.0

[fntlnz]

Removing this from the milestone since we have to make a community decision on how to handle those. Same comment as this one #1044 (comment)

This kind of thing doesn't really need to cut a release.

:)

[leodido]

@leogr this is the PR I was mentioning to you before, too

[leodido]

Superseded by #1044

/close

[poiana]

@leodido: Closed this PR.

In response to this:

Superseded by #1044

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.