Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#355 Add device parameter to UrdfRobotModel #356

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

thomasweng15
Copy link
Contributor

@thomasweng15 thomasweng15 commented Nov 7, 2022

Motivation and Context

Existing Feature Request: #355

How Has This Been Tested

Updated tests in tests/embodied/kinematics/test_urdf_model.py.
The test currently defaults to device=cuda:0 if cuda exists: https://github.com/thomasweng15/theseus/blob/3faa926334584596684eaadf0f082c4950ee763e/tests/embodied/kinematics/test_urdf_model.py#L24.
But I have also tested with device=cpu.
In both cases the tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
@mhmukadam mhmukadam self-requested a review November 7, 2022 18:47
@mhmukadam mhmukadam added the refactor Refactor library components label Nov 7, 2022
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Looks good so far. We should add to() as discussed offline.

@thomasweng15
Copy link
Contributor Author

from offline discussion -- to() requires changes to DRM upstream, current changes in PR are sufficient for running NGDF and can be merged.

Copy link
Contributor

@exhaustin exhaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, looks good in general.
Thanks for adding!

theseus/embodied/kinematics/kinematics_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge as is. I can add the changes discussed offline later today.

@mhmukadam mhmukadam merged commit a8d6034 into facebookresearch:main Nov 8, 2022
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add device parameter to UrdfRobotModel in theseus/embodied/kinematics/kinematics_model.py
5 participants