-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#355 Add device parameter to UrdfRobotModel #356
#355 Add device parameter to UrdfRobotModel #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Looks good so far. We should add to()
as discussed offline.
from offline discussion -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, looks good in general.
Thanks for adding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's merge as is. I can add the changes discussed offline later today.
…research#356) * Add device parameter to UrdfRobotModel
Motivation and Context
Existing Feature Request: #355
How Has This Been Tested
Updated tests in
tests/embodied/kinematics/test_urdf_model.py
.The test currently defaults to
device=cuda:0
if cuda exists: https://github.com/thomasweng15/theseus/blob/3faa926334584596684eaadf0f082c4950ee763e/tests/embodied/kinematics/test_urdf_model.py#L24.But I have also tested with
device=cpu
.In both cases the tests pass.
Types of changes
Checklist