Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device parameter to UrdfRobotModel in theseus/embodied/kinematics/kinematics_model.py #355

Closed
thomasweng15 opened this issue Nov 7, 2022 · 0 comments · Fixed by #356

Comments

@thomasweng15
Copy link
Contributor

🚀 Feature

Add device parameter to UrdfRobotModel in theseus/embodied/kinematics/kinematics_model.py

Motivation

Placing the robot model on gpu would enable faster operations

Pitch

Update init of UrdfRobotModel to pass a device flag to self.drm_model

Alternatives

Keep the status quo and only perform operations on cpu

Additional context

See the pre-existing device flag in the differentiable-robot-model repo that is not exposed in UrdfRobot Model: https://github.com/facebookresearch/differentiable-robot-model/blob/d7bd1b3b8ef1d6dabe9b68474a622185c510e112/differentiable_robot_model/robot_model.py#L94

thomasweng15 added a commit to thomasweng15/theseus that referenced this issue Nov 7, 2022
@mhmukadam mhmukadam linked a pull request Nov 7, 2022 that will close this issue
11 tasks
mhmukadam pushed a commit that referenced this issue Nov 8, 2022
* Add device parameter to UrdfRobotModel
suddhu pushed a commit to suddhu/theseus that referenced this issue Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant