Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parseExportNamesInto specifiers typo #22537

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix: parseExportNamesInto specifiers typo #22537

merged 1 commit into from
Dec 23, 2021

Conversation

btea
Copy link
Contributor

@btea btea commented Oct 11, 2021

fix typo :

specificers -> specifiers

@sizebot
Copy link

sizebot commented Oct 11, 2021

Comparing: afcb9cd...0d82b6c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.05 kB 130.05 kB = 41.34 kB 41.34 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.88 kB 132.88 kB = 42.31 kB 42.31 kB
facebook-www/ReactDOM-prod.classic.js = 413.81 kB 413.81 kB = 76.47 kB 76.47 kB
facebook-www/ReactDOM-prod.modern.js = 402.39 kB 402.39 kB = 74.74 kB 74.73 kB
facebook-www/ReactDOMForked-prod.classic.js = 413.81 kB 413.81 kB = 76.47 kB 76.47 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0d82b6c

Biki-das
Biki-das approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@Biki-das Biki-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@facebook-github-bot
Copy link

Hi @btea!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

bvaughn
bvaughn reviewed Nov 15, 2021
View reviewed changes
packages/react-server-dom-webpack/src/ReactFlightWebpackNodeLoader.js
if (node.specifiers) {
const specifiers = node.specifiers;
for (let j = 0; j < specifiers.length; j++) {
addExportNames(names, specifiers[j].exported);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't understand your question.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the code that was there before– node.specificers –ever work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably didn’t. :) would be good to recreate a case where this codepath runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tagged Sebastian on the original PR.

@gaearon gaearon mentioned this pull request Nov 25, 2021
Closed
8 tasks
@bvaughn bvaughn mentioned this pull request Dec 23, 2021
Closed
@bvaughn bvaughn merged commit 3dc41d8 into facebook:main Dec 23, 2021
@btea btea deleted the fix-typo branch December 24, 2021 01:56
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 10, 2022
@kacieb @facebook-github-bot
React Native sync for revisions a049aa0...fe905f1
85ecb00 
Summary:
This sync includes the following changes:
- **[fe905f152](facebook/react@fe905f152 )**: Update package.json ([#22954](facebook/react#22954)) //<Jack Works>//
- **[3dc41d8a2](facebook/react@3dc41d8a2 )**: fix: parseExportNamesInto specifiers typo ([#22537](facebook/react#22537)) //<btea>//
- **[bd0a5dd68](facebook/react@bd0a5dd68 )**: #22988 - Fix Bug: license header in React 18 bundles contains vundefined ([#23004](facebook/react#23004)) //<Vitalie>//
- **[ceee524a8](facebook/react@ceee524a8 )**: Remove unnecessary clearContainer call ([#22979](facebook/react#22979)) //<Sebastian Markbåge>//
- **[cd1a3e9b5](facebook/react@cd1a3e9b5 )**: Build both a partial renderer and fizz renderer of the legacy API for FB ([#22933](facebook/react#22933)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions a049aa0...fe905f1

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D33512179

fbshipit-source-id: c2df06c8af6bb674ea0c5524538259e6d6d98f78
@gaearon gaearon mentioned this pull request Mar 29, 2022
Merged
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@btea @zhengjitf
fix: parseExportNamesInto specifiers typo (facebook#22537)
5d88b58
nevilm-lt pushed a commit to nevilm-lt/react that referenced this pull request Apr 22, 2022
@btea @nevilm-lt
fix: parseExportNamesInto specifiers typo (facebook#22537)
69e888f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon left review comments

@Biki-das Biki-das Biki-das approved these changes

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@btea @sizebot @facebook-github-bot @bvaughn @gaearon @Biki-das