Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone for NativeComponents] RCTTabBarItem #23004

Closed
wants to merge 1 commit into from
Closed

[Standalone for NativeComponents] RCTTabBarItem #23004

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Jan 15, 2019

This pull request is part of #22990.

Changelog:

[iOS] [Changed] - Split RCTTabBarItem into RCTTabBarItemNativeComponent.

Test Plan:

  • npm run lint
  • npm run flow-check-ios
  • npm run flow
  • npm run test
  • npm run build-ios-e2e
  • npm run test-ios-e2e

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2019
@Leko Leko changed the title Create standalone JS file for RCTTabBarItem [Standalone for NativeComponents] RCTTabBarItem Jan 15, 2019
@rickhanlonii rickhanlonii self-assigned this Jan 16, 2019
rickhanlonii
rickhanlonii approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

facebook-github-bot
facebook-github-bot reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@Leko merged commit 35823ec into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 16, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@Leko @facebook-github-bot
RCTTabBarItem (facebook#23004)
ed4e78d 
Summary:
This pull request is part of facebook#22990.

Changelog:
----------

[iOS] [Changed] - Split RCTTabBarItem into RCTTabBarItemNativeComponent.
Pull Request resolved: facebook#23004

Reviewed By: TheSavior

Differential Revision: D13690820

Pulled By: rickhanlonii

fbshipit-source-id: 522e55ee74a797a3930edf6821c6d8f72511cd2b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees

@rickhanlonii rickhanlonii

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leko @react-native-bot @rickhanlonii @facebook-github-bot