Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed targeting of wrong object #23022

Closed
wants to merge 1 commit into from
Closed

Conversation

Biki-das
Copy link
Contributor

It looks like we are accessing the wrong object from the node

@sizebot
Copy link

sizebot commented Dec 23, 2021

Comparing: 2021234...6989de1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.52 kB 129.52 kB = 41.53 kB 41.53 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.65 kB 134.65 kB = 43.01 kB 43.01 kB
facebook-www/ReactDOM-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB
facebook-www/ReactDOM-prod.modern.js = 417.45 kB 417.45 kB = 77.06 kB 77.06 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 6989de1

@bvaughn
Copy link
Contributor

bvaughn commented Dec 23, 2021

I appreciate this PR, but we already have one open that makes this change (#22537) waiting on input from @sebmarkbage. Let's close this one and land that one. Sorry!

@bvaughn bvaughn closed this Dec 23, 2021
@Biki-das
Copy link
Contributor Author

I understand😉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants