[CS] Split Host Config Out into a Mutable or Immutable Mode #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we didn't have enough RN experiments. I want to add one more.
This makes it easier to do feature detection on the configuration.
This is the same as committing deletions but instead of finding host components to delete, it only invokes componentWillUnmount and detaching of refs.
This mode will use a clone based API instead of mutating host instances. Needs implementation still. It's awkward that there can be more than one child inserted into the root. So we need a new API to create a "root" instance so that we can update it atomically. Alternatively we could keep the mutable API for containers and assume that most use cases would only have a single root.
acdlite
reviewed
Oct 13, 2017
| continue; | ||
| } | ||
| var value = props[key]; | ||
| if (typeof value === 'function') { |
acdlite
reviewed
Oct 13, 2017
| }, | ||
| }); | ||
|
|
||
| const roots = new Map(); |
There was a problem hiding this comment.
What's this for? Copypasta?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immutable mode assumes that the output of React is a persistent tree, not mutations on a mutable DOM tree. Useful for targeting frameworks that accept immutable data structures as input.
Also adding another experimental RN renderer (CS) to try this out.