-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flow Coverage to Renderer Fixture, or use a maintained renderer for tests #11220
Comments
I was wanting to try to generate a
|
👍 |
I could look into this, too. The caveat is that it has to be a renderer with no internal dependencies (which |
#11683 solves this by running bundle tests (which I added) against the real reconciler bundles. (This means ReactNoop CommonJS build is now using the reconciler package.) So I deleted the fixture. |
The renderer package contains a fixture that has to be updated every time we change APIs. However it is not covered by Flow nor by full test coverage so it is very tedious to make sure you get it exactly right.
I messed it up in #11213
Making changes to the API also means updating a lot of renderers at this point. It would be nice if the fixture could be built on top of the Noop renderer or something.
cc @iamdustan @gaearon
The text was updated successfully, but these errors were encountered: