Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS] Split Host Config Out into a Mutable or Immutable Mode #11213

Merged
merged 8 commits into from
Oct 13, 2017
Merged

[CS] Split Host Config Out into a Mutable or Immutable Mode #11213

merged 8 commits into from
Oct 13, 2017

Commits on Oct 13, 2017

  1. CS renderer 

    Because we didn't have enough RN experiments. I want to add one more.
    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    6d2d40f View commit details
    Browse the repository at this point in the history

  2. Split out hydration from the host config object 

    This makes it easier to do feature detection on the configuration.
    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    554a1a1 View commit details
    Browse the repository at this point in the history

  3. Move mutation host config to separate optional object

    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    99cd494 View commit details
    Browse the repository at this point in the history

  4. Refs and life-cycles should happen even in immutable mode

    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    8080023 View commit details
    Browse the repository at this point in the history

  5. Unmount components even in non-mutation mode 

    This is the same as committing deletions but instead of finding host
components to delete, it only invokes componentWillUnmount and detaching
of refs.
    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    6e0a222 View commit details
    Browse the repository at this point in the history

  6. Add persistent updates API 

    This mode will use a clone based API instead of mutating host instances.

Needs implementation still.

It's awkward that there can be more than one child inserted into the root.
So we need a new API to create a "root" instance so that we can update it
atomically. Alternatively we could keep the mutable API for containers
and assume that most use cases would only have a single root.
    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    6524d77 View commit details
    Browse the repository at this point in the history

  7. Package up CS renderer

    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    388a068 View commit details
    Browse the repository at this point in the history

  8. Fix reconciler package fixture

    @sebmarkbage
    sebmarkbage committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    ac81b7e View commit details
    Browse the repository at this point in the history