Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix #45930

Closed
wants to merge 2 commits into from
Closed

Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix #45930

wants to merge 2 commits into from

Commits on Aug 8, 2024

  1. Do not destroy views when there is a touch going on for New Architecture 

    Summary:
This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore.

The JSTouchDispatcher already retains the information on which tag was the touch originally fired.
We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted.

This is causing a couple of bad bugs on Android:

Fixes facebook#45126
Fixes facebook#44610

Changelog:
[Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture

Differential Revision: D60594878
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5227fb2 View commit details
    Browse the repository at this point in the history

  2. Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to g… 

    …ate the Pressable fix (facebook#45930)

Summary:
Pull Request resolved: facebook#45930

This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the
fix for bug facebook#45126 and facebook#44610.

Changelog:
[Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix

Reviewed By: mdvacca

Differential Revision: D60908117
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7e1f489 View commit details
    Browse the repository at this point in the history