Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix #45930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60908117 |
|
This pull request was exported from Phabricator. Differential Revision: D60908117 |
cortinico
force-pushed
the
export-D60908117
branch
from
afc22fb
to
afb15bf
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 7, 2024
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Reviewed By: mdvacca Differential Revision: D60908117
|
This pull request was exported from Phabricator. Differential Revision: D60908117 |
cortinico
force-pushed
the
export-D60908117
branch
from
afb15bf
to
81f1683
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 7, 2024
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Differential Revision: D60908117
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Reviewed By: mdvacca Differential Revision: D60908117
|
This pull request was exported from Phabricator. Differential Revision: D60908117 |
cortinico
force-pushed
the
export-D60908117
branch
from
81f1683
to
7e1f489
Compare
|
This pull request has been merged in 92dff73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This introduces the
enableEventEmitterRetentionDuringGesturesOnAndroidthat allows us to gate thefix for bug #45126 and #44610.
Changelog:
[Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix
Differential Revision: D60908117