-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated.View::onPanResponderMove
Stops Updating Animated.Value
When Child Element Is Deleted
#45126
Labels
API: Animated
API: PanResponder
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Resolution: Fixed
A PR that fixes this issue has been merged.
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
Comments
kasperski95
added
Needs: Triage 🔍
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
labels
Jun 24, 2024
cortinico
added
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
and removed
Needs: Triage 🔍
labels
Jun 24, 2024
Thanks for reporting this @kasperski95 Just out of curiosity: have you experienced this isssue from using a library (if so, which one) or directly inside your app? |
@kasperski95 out of curiosity, is this issue happening also on iOS? |
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 1, 2024
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
…ate the Pressable fix Summary: This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Differential Revision: D60908117
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Reviewed By: mdvacca Differential Revision: D60908117
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 7, 2024
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Differential Revision: D60908117
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 8, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Reviewed By: mdvacca Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 8, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Reviewed By: mdvacca Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 8, 2024
Summary: This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
added a commit
to cortinico/react-native
that referenced
this issue
Aug 8, 2024
…ate the Pressable fix (facebook#45930) Summary: Pull Request resolved: facebook#45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug facebook#45126 and facebook#44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Reviewed By: mdvacca Differential Revision: D60908117
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 8, 2024
…ate the Pressable fix (#45930) Summary: Pull Request resolved: #45930 This introduces the `enableEventEmitterRetentionDuringGesturesOnAndroid` that allows us to gate the fix for bug #45126 and #44610. Changelog: [Internal] [Changed] - Introduce the enableEventEmitterRetentionDuringGesturesOnAndroid to gate the Pressable fix Reviewed By: mdvacca Differential Revision: D60908117 fbshipit-source-id: 885917832718d9b90d043b2d7e2cdb47e0f01ea7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API: Animated
API: PanResponder
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Resolution: Fixed
A PR that fixes this issue has been merged.
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
Description
When a child element inside an
Animated.View
is deleted, theonPanResponderMove
stops updating anAnimated.Value
, which stops the dragging animation. This issue doesn't exist on old architecture.Steps to reproduce
React Native Version
0.74.2
Affected Platforms
Runtime - Android, Other (please specify)
Areas
Fabric - The New Renderer
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/kasperski95/repro-rn-na-pan-responder-issue
Screenshots and Videos
New Architecture
NEW_ARCHITECTURE.mov
Old Architecture (expected behavior)
OLD_ARCHITECTURE.mov
The text was updated successfully, but these errors were encountered: