Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move libmapbufferjni.so inside libreactnative.so #45641

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Move libmapbufferjni.so inside libreactnative.so #45641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64cf2b3
Create the libreactnative.so dependency
cortinico Jul 23, 2024
37c960e
Remove several libs from default App CMake setup
cortinico Jul 23, 2024
5e22b32
Move react_featureflags and react_render_consistency inside libreactn…
cortinico Jul 23, 2024
803a8fa
Move react_codegen_* + react_nativemodules_* libraries to static linking
cortinico Jul 24, 2024
2eae374
Move libreact_newarchdefaults.so inside libreactnative.so
cortinico Jul 24, 2024
897efb4
Move libmapbufferjni.so inside libreactnative.so (#45641)
cortinico Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move react_featureflags and react_render_consistency inside libreactn… 
…ative.so

Summary:
Other two libraries that don't need to be dynamic libraries but can just be exposed via libreactnative.so

Changelog:
[Internal] [Changed] -  Move react_featureflags and react_render_consistency inside libreactnative.so

Differential Revision: D55796945
  • Loading branch information
@cortinico @facebook-github-bot
cortinico authored and facebook-github-bot committed Jul 23, 2024
commit 5e22b321ef3c5583441364c1b3d1c8ae97b375cf
4 changes: 4 additions & 0 deletions packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,11 @@ add_library(reactnative
$<TARGET_OBJECTS:logger>
$<TARGET_OBJECTS:react_bridging>
$<TARGET_OBJECTS:react_debug>
$<TARGET_OBJECTS:react_featureflags>
$<TARGET_OBJECTS:react_nativemodule_core>
$<TARGET_OBJECTS:react_render_attributedstring>
$<TARGET_OBJECTS:react_render_componentregistry>
$<TARGET_OBJECTS:react_render_consistency>
$<TARGET_OBJECTS:react_render_core>
$<TARGET_OBJECTS:react_render_debug>
$<TARGET_OBJECTS:react_render_dom>
Expand Down Expand Up @@ -190,9 +192,11 @@ target_include_directories(reactnative
PUBLIC
$<TARGET_PROPERTY:react_bridging,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_debug,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_featureflags,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_nativemodule_core,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_attributedstring,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_componentregistry,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_consistency,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_core,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_debug,INTERFACE_INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:react_render_dom,INTERFACE_INCLUDE_DIRECTORIES>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/featureflags/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ add_compile_options(
-DLOG_TAG=\"ReactNative\")

file(GLOB react_featureflags_SRC CONFIGURE_DEPENDS *.cpp)
add_library(react_featureflags SHARED ${react_featureflags_SRC})
add_library(react_featureflags OBJECT ${react_featureflags_SRC})

target_include_directories(react_featureflags PUBLIC ${REACT_COMMON_DIR})
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ add_compile_options(
-DLOG_TAG=\"Fabric\")

file(GLOB react_render_consistency_SRC CONFIGURE_DEPENDS *.cpp)
add_library(react_render_consistency SHARED ${react_render_consistency_SRC})
add_library(react_render_consistency OBJECT ${react_render_consistency_SRC})

target_include_directories(react_render_consistency PUBLIC ${REACT_COMMON_DIR})