Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libmapbufferjni.so inside libreactnative.so #45641

Closed
wants to merge 6 commits into from

Commits on Jul 23, 2024

  1. Create the libreactnative.so dependency

    Summary:
    This creates a new dynamic library that we want to be the only .so that is loaded from apps/libraries.
    
    Changelog:
    [Internal] [Changed] - Create the libreactnative.so dependency
    
    Differential Revision: D55751682
    cortinico authored and facebook-github-bot committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    64cf2b3 View commit details
    Browse the repository at this point in the history
  2. Remove several libs from default App CMake setup

    Summary:
    As we're moving towards a single `libreactnative.so` file, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader.
    
    This is breaking for libraries using native dependencies via Prefab (i.e. search for `ReactAndroid::` in CMakeLists.txt files for your project).
    
    If so, the CMakeLists.txt files should be updated as follows:
    
    ```diff
    - ReactAndroid::react_render_debug
    + ReactAndroid::reactnative
    ```
    
    This applies to every prefab dependencies (the example is just for `react_render_debug`
    
    Changelog:
    [General] [Breaking] - Remove several libs from default App CMake setup
    
    Differential Revision: D55751683
    cortinico authored and facebook-github-bot committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    37c960e View commit details
    Browse the repository at this point in the history
  3. Move react_featureflags and react_render_consistency inside libreactn…

    …ative.so
    
    Summary:
    Other two libraries that don't need to be dynamic libraries but can just be exposed via libreactnative.so
    
    Changelog:
    [Internal] [Changed] -  Move react_featureflags and react_render_consistency inside libreactnative.so
    
    Differential Revision: D55796945
    cortinico authored and facebook-github-bot committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5e22b32 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Move react_codegen_* + react_nativemodules_* libraries to static linking

    Summary:
    There is a circular dependency between libreactnative.so and libreact_codegen_rncore.so which I'm breaking here.
    
    Changelog:
    [Internal] [Changed] - Move react_codegen_* + react_nativemodules_* libraries to static linking
    
    Differential Revision: D55799200
    cortinico authored and facebook-github-bot committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    803a8fa View commit details
    Browse the repository at this point in the history
  2. Move libreact_newarchdefaults.so inside libreactnative.so

    Summary:
    This is a more complex library as I had to introduce a `ReactNativeSoLoader` to handle the internal/oss scenarios.
    
    Changelog:
    [Internal] [Changed] - Move libreact_newarchdefaults.so inside libreactnative.so
    
    Differential Revision: D55796933
    cortinico authored and facebook-github-bot committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2eae374 View commit details
    Browse the repository at this point in the history
  3. Move libmapbufferjni.so inside libreactnative.so (facebook#45641)

    Summary:
    Pull Request resolved: facebook#45641
    
    Moving another library inside libreactnative.so
    
    Changelog:
    [Internal] [Changed] - Move libmapbufferjni.so inside libreactnative.so
    
    Reviewed By: javache
    
    Differential Revision: D55799199
    cortinico authored and facebook-github-bot committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    897efb4 View commit details
    Browse the repository at this point in the history