Move libmapbufferjni.so inside libreactnative.so #45641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This creates a new dynamic library that we want to be the only .so that is loaded from apps/libraries. Changelog: [Internal] [Changed] - Create the libreactnative.so dependency Differential Revision: D55751682
Summary: As we're moving towards a single `libreactnative.so` file, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader. This is breaking for libraries using native dependencies via Prefab (i.e. search for `ReactAndroid::` in CMakeLists.txt files for your project). If so, the CMakeLists.txt files should be updated as follows: ```diff - ReactAndroid::react_render_debug + ReactAndroid::reactnative ``` This applies to every prefab dependencies (the example is just for `react_render_debug` Changelog: [General] [Breaking] - Remove several libs from default App CMake setup Differential Revision: D55751683
…ative.so Summary: Other two libraries that don't need to be dynamic libraries but can just be exposed via libreactnative.so Changelog: [Internal] [Changed] - Move react_featureflags and react_render_consistency inside libreactnative.so Differential Revision: D55796945
Summary: There is a circular dependency between libreactnative.so and libreact_codegen_rncore.so which I'm breaking here. Changelog: [Internal] [Changed] - Move react_codegen_* + react_nativemodules_* libraries to static linking Differential Revision: D55799200
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55799199 |
Summary: This is a more complex library as I had to introduce a `ReactNativeSoLoader` to handle the internal/oss scenarios. Changelog: [Internal] [Changed] - Move libreact_newarchdefaults.so inside libreactnative.so Differential Revision: D55796933
Summary: Pull Request resolved: facebook#45641 Moving another library inside libreactnative.so Changelog: [Internal] [Changed] - Move libmapbufferjni.so inside libreactnative.so Reviewed By: javache Differential Revision: D55799199
|
This pull request was exported from Phabricator. Differential Revision: D55799199 |
cortinico
force-pushed
the
export-D55799199
branch
from
e410603
to
897efb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moving another library inside libreactnative.so
Changelog:
[Internal] [Changed] - Move libmapbufferjni.so inside libreactnative.so
Reviewed By: javache
Differential Revision: D55799199