Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'[skip ci] [RN][JS] BridgelessUIManager: Finish focus, blur #42210

Closed
wants to merge 9 commits into from
Closed

'[skip ci] [RN][JS] BridgelessUIManager: Finish focus, blur #42210

wants to merge 9 commits into from

Commits on Jan 10, 2024

  1. [skip ci] BridgelessUIManager: Align platform-only methods w/ PaperUI… 

    …Manager (facebook#41997)

Summary:

Many methods on PaperUIMangaer are iOS only.

Many methods on PaperUIManager are Android  only.

This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D52012876
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a024662 View commit details
    Browse the repository at this point in the history

  2. [skip ci] BridgelessUIManager: Finish createView, updateView, setChil… 

    …dren, manageChildren (facebook#42067)

Summary:

These methods should not be implemented in the new architecture.

The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D52345416
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e47c04f View commit details
    Browse the repository at this point in the history

  3. [skip ci] BridgelessUIManager: Improve error message for getViewManag… 

    …erConfig() (facebook#41998)

Summary:

Now the error message propts people to turn on the interop layer.

And, it adds more details to the suggestion to use hasViewManager(viewManagerName).

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D52002909
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ba4944c View commit details
    Browse the repository at this point in the history

  4. [skip ci] UIManager: Delete removeSubviewsFromContainerWithID (facebo… 

    …ok#42066)

Summary:

We should just delete this UIManagerModule api:
- There are no usages of this api at Meta
- The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5)

Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID

Reviewed By: sammy-SC

Differential Revision: D52345629
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d2e6fd3 View commit details
    Browse the repository at this point in the history

  5. [skip ci] UIManager: Delete replaceExistingNonRootView (facebook#42065) 

    Summary:

We should delete from UIManager:
- There are no usages of this api at Meta.
- The only usages found on GitHub are from old forks of React Native: [Github search](https://github.com/search?q=replaceExistingNonRootView+language%3AJavaScript&type=code&p=5&l=JavaScript)

Changelog: [Android][Removed] - Delete UIManager.replaceExistingNonRootView

Reviewed By: sammy-SC

Differential Revision: D52345872
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a5d7204 View commit details
    Browse the repository at this point in the history

  6. [skip ci] BridgelessUIManager: Finish configureNextLayoutAnimation (f… 

    …acebook#42211)

Summary:

According to [LayoutAnimation.js](https://github.com/facebook/react-native/blob/2b63b9bba98cfe142581b47cc20bd3068e3e4281/packages/react-native/Libraries/LayoutAnimation/LayoutAnimation.js#L78-L101), UIManager.configureNextLayoutAnimation can just delegate to FabricUIManager.

Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D52347537
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6483f9c View commit details
    Browse the repository at this point in the history

  7. [skip ci] BridgelessUIManager: Finish setLayoutAnimationEnabledExperi… 

    …mental (facebook#42207)

Summary:

In open source, with the new architecture, layout animations are **always** enabled.

They cannot be disabled.

Therefore, when this UIManagerModule method is called with false, just report an error. That way, if layout animations were explicitly disabled on Android, the developer will know, when they try to enable the new architecture.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D52349297
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    101d6ca View commit details
    Browse the repository at this point in the history

  8. [skip ci] BridgelessUIManager: Finish sendAccessibilityEvent (faceboo… 

    …k#42216)

Summary:

Changelog: [Internal]

Reviewed By: dmytrorykun

Differential Revision: D52383282
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    abae887 View commit details
    Browse the repository at this point in the history

  9. BridgelessUIManager: Finish focus, blur (facebook#42210) 

    Summary:

Implement Focus and blur, by using commands.

Changelog: [Internal]

Reviewed By: dmytrorykun

Differential Revision: D52383997
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    697d406 View commit details
    Browse the repository at this point in the history