'[skip ci] [RN][JS] BridgelessUIManager: Finish focus, blur #42210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52383997 |
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
…erConfig() (facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
…ok#42066) Summary: We should just delete this UIManagerModule api: - There are no usages of this api at Meta - The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5) Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID Reviewed By: sammy-SC Differential Revision: D52345629
Summary: We should delete from UIManager: - There are no usages of this api at Meta. - The only usages found on GitHub are from old forks of React Native: [Github search](https://github.com/search?q=replaceExistingNonRootView+language%3AJavaScript&type=code&p=5&l=JavaScript) Changelog: [Android][Removed] - Delete UIManager.replaceExistingNonRootView Reviewed By: sammy-SC Differential Revision: D52345872
…acebook#42211) Summary: According to [LayoutAnimation.js](https://github.com/facebook/react-native/blob/2b63b9bba98cfe142581b47cc20bd3068e3e4281/packages/react-native/Libraries/LayoutAnimation/LayoutAnimation.js#L78-L101), UIManager.configureNextLayoutAnimation can just delegate to FabricUIManager. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D52347537
…mental (facebook#42207) Summary: In open source, with the new architecture, layout animations are **always** enabled. They cannot be disabled. Therefore, when this UIManagerModule method is called with false, just report an error. That way, if layout animations were explicitly disabled on Android, the developer will know, when they try to enable the new architecture. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52349297
…k#42216) Summary: Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D52383282
Summary: Implement Focus and blur, by using commands. Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D52383997
RSNara
force-pushed
the
export-D52383997
branch
from
24d2882
to
697d406
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52383997 |
|
This pull request has been merged in 8fd2f12. |
Base commit: 9525074 |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
Summary: Pull Request resolved: facebook#42210 Implement Focus and blur, by using commands. Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D52383997 fbshipit-source-id: ca3c20d77b17147b592cbf3c48772b857a2e2c55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement Focus and blur, by using commands.
Changelog: [Internal]
Reviewed By: dmytrorykun
Differential Revision: D52383997