BridgelessUIManager: Align platform-only methods w/ PaperUIManager #41997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
a32a7b5
to
65e641a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
65e641a
to
0c51194
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
force-pushed
the
export-D52012876
branch
2 times, most recently
from
b77c800
to
6c2b506
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
force-pushed
the
export-D52012876
branch
from
6c2b506
to
85143e9
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
85143e9
to
cee7ed3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
cee7ed3
to
d608f51
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
d608f51
to
17ef3f0
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Dec 26, 2023
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
17ef3f0
to
152c0c2
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 678a21a0f52ba87d9d0d8843dc414dff5c672cb3
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 1ad8327937d173f7e9fdde345102ad3f3a630a69
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 3f7aff6d73c5b63bd1d905c2b527544e7b0c03b4
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: f6c2e521e49bfeb6a21b952bff881eb843a931c0
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: f45529fa33842e0571507c54aed381a9d9a47669
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…w/ PaperUIManager (facebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: c58402b443004e71ebae9d3c214a3a13d9dcb1b5
RSNara
force-pushed
the
export-D52012876
branch
from
bd2a0c6
to
c85265e
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 88fb5de9aa9b0c4e7294f12f7d82d18233b98875
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: d361b1324855ec782664df7c4eda2d8ec60c1e1c
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: db5d3d0a5947e2379b143f190234d5df270dbaa7
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: c813be1240331f53d3568dc2e30e0e22798c5320
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 43a662ed0a4a56a623b5a83c0862da6da0e0ee3c
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: dab04af2b14cf44723ef1bf79afed5ddc2b96b3b
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 2fc765737234e4e2f5264dd64efc56b5e970b849
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 4f8925c126fdff7cd431c76d7f0998c2a3625adb
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 8a38ef0570bcbdf8858a22837f2d75671c86bb7c
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: d126b34271b9ccabdb395e26a85d6068fb43247f
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 2c7802df97522b56633e707290c3591c2a1462c6
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: f40cf84281b03cacdc431e264ec6084eb7c90171
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
force-pushed
the
export-D52012876
branch
from
c85265e
to
6dfdd6b
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was successfully merged by @RSNara in 4ed4ea1. When will my fix make it into a release? | Upcoming Releases |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: 6527048083eae93577a58d4b77f0645fab84217f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Many methods on PaperUIMangaer are iOS only.
Many methods on PaperUIManager are Android only.
This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS.
Changelog: [Internal]
Differential Revision: D52012876