Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debugging overlays should not have explicit height #41750

Closed
wants to merge 10 commits into from
Closed

fix: debugging overlays should not have explicit height #41750

wants to merge 10 commits into from

Commits on Jan 15, 2024

  1. refactor[ReadOnlyNode]: lazy import ReactFabric 

    Summary:
Changelog: [Internal]

Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications.

Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import.

Differential Revision: D52784886

fbshipit-source-id: cf2685b3dfeca162d7a4e5e1aa303b0cfc194b11
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5be1618 View commit details
    Browse the repository at this point in the history

  2. fix[getInternalInstanceHandleFromPublicInstance]: make it backwards c… 

    …ompatible with previous Fabric implementation

Summary:
Changelog: [Internal]

Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version.

Fabric host components store internal instance in __internalInstanceHandle field,  previously they have been storing it in the field with the same name, but with one underscore in prefix:
https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151

Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix.

Differential Revision: D52697886

fbshipit-source-id: ee5c3a60f8bf4251ba28897d58bd6ce9fc008c1a
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3b73533 View commit details
    Browse the repository at this point in the history

  3. fix: patch public renderer implementations to include isChildPublicIn… 

    …stance

Summary:
Changelog: [Internal]

Manually patching public React renderers artifacts to include `isChildPublicInstance` method, which was added in facebook/react#27783.

To identifly the required changes in code I've ran a diff for 2 commits:
1. The one with the changes
2. Its parent

FB implementation were synced in D51816108.

Differential Revision: D52697885

fbshipit-source-id: b8dfbc641899516c7c62bb79bd21fae1a1981a0c
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6104d70 View commit details
    Browse the repository at this point in the history

  4. feat[DebuggingOverlayRegistry]: basic implementation (facebook#41743) 

    Summary:
Pull Request resolved: facebook#41743

Changelog: [Internal]

There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.

It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods.

In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements.

Differential Revision: D51536787

Reviewed By: rshest

fbshipit-source-id: a6a64ef5f2cec6eb10881275929272ce02038c20
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0e25f07 View commit details
    Browse the repository at this point in the history

  5. refactor: DebuggingOverlayRegistry to handle trace updates (facebook#… 

    …41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 7ec87efc1ba07efe98cf9788560088653bb05856
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    8ebb7a0 View commit details
    Browse the repository at this point in the history

  6. feat[DebuggingOverlay]: support native commands for highlighting elem… 

    …ents

Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51603861

fbshipit-source-id: c836f301b38831b3ecdd6170e3077ae8a09229e3
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    39cd0f1 View commit details
    Browse the repository at this point in the history

  7. refactor: DebuggingOverlayRegistry to handle native highlights from R… 

    …eact DevTools (facebook#41746)

Summary:
Pull Request resolved: facebook#41746

Changelog: [Internal]

Now using previously added `highlightElements` and `clearElementsHighlights` commands.

[Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times.

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51708053

Reviewed By: sammy-SC

fbshipit-source-id: 97f85f7b236602da9bc1b7bacf6c347ce67faec8
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    8b690da View commit details
    Browse the repository at this point in the history

  8. refactor: use same rectangle spec for DebuggingOverlay native commands 

    Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51708055

fbshipit-source-id: 8cf3e4a1cd39c45c7350a9a06b9eab70909559b5
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6974049 View commit details
    Browse the repository at this point in the history

  9. refactor: improve trace updates highlighting 

    Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51708054

fbshipit-source-id: 33a2b89f1889963057593f3c4f296e3048a3c88c
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f068a76 View commit details
    Browse the repository at this point in the history

  10. fix: debugging overlays should not have explicit height (facebook#41750) 

    Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 277a19f3cf55e1113ce3522db4eae69274b28f7f
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    90229f9 View commit details
    Browse the repository at this point in the history