refactor: DebuggingRegistry to handle native highlights from React DevTools #41746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
Base commit: af8c56a |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 1, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
hoxyq
force-pushed
the
export-D51708053
branch
from
02e9e7a
to
b4ed6a7
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 1, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
b4ed6a7
to
b2362e9
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
hoxyq
force-pushed
the
export-D51708053
branch
from
b2362e9
to
ba56187
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
ba56187
to
281d926
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 7, 2023
…vTools (facebook#41746) Summary: Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods. For some methods actual implementation will be published in the next diffs. Differential Revision: https://internalfb.com/D51536787 fbshipit-source-id: d0ee320c35f003901b9f1e46619970c4a51c6fd1
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603860 fbshipit-source-id: 0c517c57e14693a30348fe11880a4ebaa30be121
…ents Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603861 fbshipit-source-id: 8ad27736735f3ea2c33dc6d5f015fb17b9cc99cb
…vTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 fbshipit-source-id: 64004323fb5120e81243764f7ce5a67e01221ed1
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
281d926
to
2e1d543
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 4, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 9c638815ec006c1beaf833a21c483f0db2e9af1a
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 4, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 975eb73b9670c3aa9e749a45128fa19f708b784e
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 5, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: a73ba0eac6769db21cde9bb9c89098d9fa322ecc
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 5, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 984a8add4bb4a0148f3e2fa0c1896b3ca956aade
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 97175a2e97e1cbfcf10134cea2059121146f2880
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 352d44e62af8f262748c804c69716dda86fb7f23
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: fb4d78af263fb8d3505265ed0f589be484fbc385
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 11, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 49c0f906f95a76c0cd6e1a2c58d790b5f39858ab
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 11, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: bb50c8c2966242807d9bc8ffeb38d2d88718d5f9
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 0c393404d515d417ab18604f77aa25c02df4ce3d
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: a6b79f79532602babbff9f484f506170492aed57
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 8b24f77fbad7838d1af8abbc444e74347eedd3b0
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (facebook#41746) Summary: Pull Request resolved: facebook#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 97f85f7b236602da9bc1b7bacf6c347ce67faec8
|
This pull request has been merged in 1b9310e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Now using previously added
highlightElementsandclearElementsHighlightscommands.[Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not number-of-rendered-AppContainers times.
All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.
Differential Revision: D51708053