Skip to content

Commit

Permalink
Making UIManager not implement JSIModule (#42061)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #42061

For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining `initialize()` and `invalidate()`

Changelog:
[Internal] internal

Reviewed By: philIip, mdvacca

Differential Revision: D49306312

fbshipit-source-id: 041870418e13bb4b2381e609b94331c87be5f6fa
  • Loading branch information
arushikesarwani94 authored and facebook-github-bot committed Jan 2, 2024
1 parent ce54772 commit af8c56a
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import androidx.annotation.UiThread;
import com.facebook.infer.annotation.ThreadConfined;

public interface UIManager extends JSIModule, PerformanceCounter {
public interface UIManager extends PerformanceCounter {

/** Registers a new root view. @Deprecated call startSurface instead */
@UiThread
Expand Down Expand Up @@ -151,4 +151,10 @@ void updateRootLayoutSpecs(
@Deprecated
@Nullable
String resolveCustomDirectEventName(@Nullable String eventName);

/** This method is called after {@link ReactApplicationContext} has been created. */
void initialize();

/** Called before React Native instance is destroyed. */
void invalidate();
}

0 comments on commit af8c56a

Please sign in to comment.