Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DebuggingRegistry to handle trace updates #41744

Closed
wants to merge 2 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Dec 1, 2023

Summary:
Changelog: [Internal]

With these changes:

  • DebuggingRegitry is responsible for listening to the events from React DevTools and
  • AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
  • [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not number-of-rendered-AppContainers times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 1, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 1, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 1, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 1, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 7, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 7, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Dec 7, 2023
Summary:

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860
Ruslan Lesiutin and others added 2 commits January 2, 2024 04:15
Summary:
Changelog: [Internal]

There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.

It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods.

For some methods actual implementation will be published in the next diffs.

Differential Revision: https://internalfb.com/D51536787

fbshipit-source-id: e27c94cebaa8dd2ef442af51807564bf84f9e138
Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860

fbshipit-source-id: 66a299e86f1318f6f95a47bdbcd2d79acaeeee0d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51603860

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 4, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: cd660ce4885c0821612bfa0b390d56509abd0bf7
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 4, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: c6c33314572ddcf49fe7481e517d6504a7ea89f6
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 4, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 9ed2476d801e43116ec0a83ad041925838434e55
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 5, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: d697026af8b93ea052bad8524f10eae4d55ac037
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 5, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 77051a3f93152dfb2f894fcac4d624895fe3f45e
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 5, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 33f9ab30a6ab242badccd7817a1de4d05a9a61cc
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 8, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 6b441a61478a91b75418574be62e194cf83dc796
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 8, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 213064c4e66e62c6cc2c8241942cf4457731e749
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 8, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 2d5ada3e8cc135646f14ca5426fac2e885c6c649
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 8, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 3a4711b42ae55eac29fb3a85ba6695b3ed54d7dd
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 11, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 741f20a167f5ab96e3df4b7b9bd683c428c8bd8f
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 11, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 4107fff607ae396818008719330d02515dda0f80
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 11, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 121c732838386f15272a004d6a4c1cbe5460180b
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: cd2e4219f545b54ebd986b4e4d085209e8ec5cdf
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 4aa530ebe6c583ebdaf80429a974d37882ff19c9
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 05f03305b478f525320d476d56d05f7cfd0a9bb8
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: b3567f8aed64845011a7478becd2fda4ac02dc36
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 7ec87efc1ba07efe98cf9788560088653bb05856
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in be255cb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants