-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: DebuggingRegistry to handle trace updates #41744
Conversation
This pull request was exported from Phabricator. Differential Revision: D51603860 |
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860
f40e0da
to
6c1f91d
Compare
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860
This pull request was exported from Phabricator. Differential Revision: D51603860 |
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860
6c1f91d
to
9a51b6b
Compare
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
This pull request was exported from Phabricator. Differential Revision: D51603860 |
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
9a51b6b
to
85b04b7
Compare
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
This pull request was exported from Phabricator. Differential Revision: D51603860 |
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
85b04b7
to
f2fa54f
Compare
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
This pull request was exported from Phabricator. Differential Revision: D51603860 |
Summary: Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods. For some methods actual implementation will be published in the next diffs. Differential Revision: https://internalfb.com/D51536787 fbshipit-source-id: e27c94cebaa8dd2ef442af51807564bf84f9e138
Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Reviewed By: sammy-SC Differential Revision: D51603860 fbshipit-source-id: 66a299e86f1318f6f95a47bdbcd2d79acaeeee0d
This pull request was exported from Phabricator. Differential Revision: D51603860 |
f2fa54f
to
cb3b8a3
Compare
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: cd660ce4885c0821612bfa0b390d56509abd0bf7
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: c6c33314572ddcf49fe7481e517d6504a7ea89f6
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 9ed2476d801e43116ec0a83ad041925838434e55
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: d697026af8b93ea052bad8524f10eae4d55ac037
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 77051a3f93152dfb2f894fcac4d624895fe3f45e
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 33f9ab30a6ab242badccd7817a1de4d05a9a61cc
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 6b441a61478a91b75418574be62e194cf83dc796
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 213064c4e66e62c6cc2c8241942cf4457731e749
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 2d5ada3e8cc135646f14ca5426fac2e885c6c649
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 3a4711b42ae55eac29fb3a85ba6695b3ed54d7dd
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 741f20a167f5ab96e3df4b7b9bd683c428c8bd8f
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 4107fff607ae396818008719330d02515dda0f80
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 121c732838386f15272a004d6a4c1cbe5460180b
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: cd2e4219f545b54ebd986b4e4d085209e8ec5cdf
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 4aa530ebe6c583ebdaf80429a974d37882ff19c9
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 05f03305b478f525320d476d56d05f7cfd0a9bb8
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: b3567f8aed64845011a7478becd2fda4ac02dc36
…41744) Summary: Pull Request resolved: facebook#41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 7ec87efc1ba07efe98cf9788560088653bb05856
This pull request has been merged in be255cb. |
Summary:
Changelog: [Internal]
With these changes:
All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.
Differential Revision: D51603860