Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DebuggingRegistry to handle trace updates #41744

Closed
wants to merge 2 commits into from
Closed

refactor: DebuggingRegistry to handle trace updates #41744

wants to merge 2 commits into from

Commits on Jan 2, 2024

  1. feat[DebuggingRegistry]: basic implementation 

    Summary:
Changelog: [Internal]

There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.

It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods.

For some methods actual implementation will be published in the next diffs.

Differential Revision: https://internalfb.com/D51536787

fbshipit-source-id: e27c94cebaa8dd2ef442af51807564bf84f9e138
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    165978f View commit details
    Browse the repository at this point in the history

  2. refactor: DebuggingRegistry to handle trace updates (facebook#41744) 

    Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Reviewed By: sammy-SC

Differential Revision: D51603860

fbshipit-source-id: 66a299e86f1318f6f95a47bdbcd2d79acaeeee0d
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    cb3b8a3 View commit details
    Browse the repository at this point in the history