Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving SurfaceHandler to react.interfaces.fabric #38759

Closed
wants to merge 2 commits into from
Closed

Moving SurfaceHandler to react.interfaces.fabric #38759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588b3f3
Revert D47915065
arushikesarwani94 Aug 3, 2023
4c2b4f5
Moving SurfaceHandler to react.interfaces.fabric (#38759)
arushikesarwani94 Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...s/react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactSurface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
import com.facebook.react.bridgeless.internal.bolts.Task;
import com.facebook.react.common.annotations.VisibleForTesting;
import com.facebook.react.fabric.SurfaceHandlerBinding;
import com.facebook.react.fabric.interfaces.SurfaceHandler;
import com.facebook.react.interfaces.ReactSurfaceInterface;
import com.facebook.react.interfaces.TaskInterface;
import com.facebook.react.interfaces.fabric.SurfaceHandler;
import com.facebook.react.modules.i18nmanager.I18nUtil;
import com.facebook.react.uimanager.events.EventDispatcher;
import java.util.concurrent.atomic.AtomicReference;
Expand Down Expand Up @@ -128,8 +128,7 @@ public void detach() {
mReactHost.set(null);
}

/** package */
SurfaceHandler getSurfaceHandler() {
public SurfaceHandler getSurfaceHandler() {
return mSurfaceHandler;
}

Expand Down
2 changes: 1 addition & 1 deletion ...es/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.fabric.events.EventEmitterWrapper;
import com.facebook.react.fabric.events.FabricEventEmitter;
import com.facebook.react.fabric.interfaces.SurfaceHandler;
import com.facebook.react.fabric.interop.InteropEventEmitter;
import com.facebook.react.fabric.mounting.MountItemDispatcher;
import com.facebook.react.fabric.mounting.MountingManager;
Expand All @@ -67,6 +66,7 @@
import com.facebook.react.fabric.mounting.mountitems.DispatchCommandMountItem;
import com.facebook.react.fabric.mounting.mountitems.MountItem;
import com.facebook.react.fabric.mounting.mountitems.MountItemFactory;
import com.facebook.react.interfaces.fabric.SurfaceHandler;
import com.facebook.react.modules.core.ReactChoreographer;
import com.facebook.react.modules.i18nmanager.I18nUtil;
import com.facebook.react.uimanager.IllegalViewOperationException;
Expand Down
2 changes: 1 addition & 1 deletion ...ct-native/ReactAndroid/src/main/java/com/facebook/react/fabric/SurfaceHandlerBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.NativeMap;
import com.facebook.react.fabric.interfaces.SurfaceHandler;
import com.facebook.react.interfaces.fabric.SurfaceHandler;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

Expand Down
2 changes: 1 addition & 1 deletion ...react/fabric/interfaces/SurfaceHandler.kt → ...react/interfaces/fabric/SurfaceHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.fabric.interfaces
package com.facebook.react.interfaces.fabric

import com.facebook.react.bridge.NativeMap
import javax.annotation.concurrent.ThreadSafe
Expand Down
2 changes: 1 addition & 1 deletion ...act-native/ReactAndroid/src/test/java/com/facebook/react/bridgeless/ReactSurfaceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import android.view.View;
import com.facebook.react.bridge.NativeMap;
import com.facebook.react.bridgeless.internal.bolts.Task;
import com.facebook.react.fabric.interfaces.SurfaceHandler;
import com.facebook.react.interfaces.fabric.SurfaceHandler;
import com.facebook.react.uimanager.events.EventDispatcher;
import java.util.concurrent.Callable;
import org.junit.Before;
Expand Down