Moving SurfaceHandler to react.interfaces.fabric #38759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48006184 |
Summary: See the discussion in D47915065. In order to expose `getSurfaceHandler()` from an interface ReactSurface in D47109982, we need this to be public. All methods in an interface are public and the implementing class can not have a restricted visibility than the interface. Differential Revision: D48003816 fbshipit-source-id: ebefeb35f7d3289a442f3885feff76387b78a57e
Summary: Pull Request resolved: facebook#38759 As part of refactoring the `ReactSurface`, moving the `SurfaceHandler` interface to `react.interfaces.fabric`. changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D48006184 fbshipit-source-id: 6c0a6eb122a89be1950f593da55cfe4dcd84698f
arushikesarwani94
force-pushed
the
export-D48006184
branch
from
c87eb2a
to
4c2b4f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48006184 |
|
This pull request has been merged in 51263cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As part of refactoring the
ReactSurface, moving theSurfaceHandlerinterface toreact.interfaces.fabric.changelog: [internal] internal
Differential Revision: D48006184